You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2017/01/20 17:38:29 UTC

[GitHub] brooklyn-client pull request #37: Add missing @Override annotations and othe...

GitHub user neykov opened a pull request:

    https://github.com/apache/brooklyn-client/pull/37

    Add missing @Override annotations and other cleanup

    Triggered by a refactoring I had to do and missing a bunch of places that needed updating.
    
    * add missing `@Override` annotations
    * add missing `@Deprecated` annotations (usually just javadoc `@override` exists)
    * remove unused imports
    * remove unnecessary casts
    
    Look at each commit individually.
    Similar PRs created for the other brooklyn sub-projects.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/brooklyn-client cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-client/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit b32a2027a99b1ba98f97e433968a0628d5f018be
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2017-01-20T14:07:33Z

    Add missing @Override annotation to method signatures overriding interface methods

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request #37: Add missing @Override annotations and othe...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-client/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client issue #37: Add missing @Override annotations and other clean...

Posted by sjcorbett <gi...@git.apache.org>.

Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-client/pull/37
  
    Thanks @neykov. The Jenkins error has been lost to time. I've verified that the build passes locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client issue #37: Add missing @Override annotations and other clean...

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-client/pull/37
  
    Thanks @googlielmo. Kicked off another build, the rat warning should already be fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client issue #37: Add missing @Override annotations and other clean...

Posted by googlielmo <gi...@git.apache.org>.

Github user googlielmo commented on the issue:

    https://github.com/apache/brooklyn-client/pull/37
  
    LGTM -- jenkins failure unrelated (RAT plugin)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---