[GitHub] [incubator-mxnet] samskalicky commented on issue #20411: 1.7.0.post2: consistent segfault in ~LibraryInitializer() with loaded extensions on OSX Mojave

[GitBox <gi...@apache.org>]

samskalicky commented on issue #20411:
URL: https://github.com/apache/incubator-mxnet/issues/20411#issuecomment-897841864


   Hi @david-seiler thanks for filing the issue. We have not done much testing of c++ custom ops on Mac (if at all). Mostly on linux and very slightly on windows. Im not aware of how OS X is different than linux kernel handling of dynamic libraries, so any help you can provide in that area would be great. 
   
   in 1.7.x we have some code in the `LibraryInitializer::~LibraryInitializer()` destructor that tries to close the custom libraries that have been opened:
   
   https://github.com/apache/incubator-mxnet/blob/a22abce0ce576ef4630aaea00cc9ad4d844f99f9/src/initialize.cc#L100-L102
   
   but in 2.0 we removed this so now the destructor doesnt do anything:
   
   https://github.com/apache/incubator-mxnet/blob/9ed058202ac1f299a1b11caf74c2a719650bf89f/src/initialize.cc#L100
   
   And then we expect the user to close the library (by calling dlclose or letting it get cleaned up by the kernel when the process exits). 
   
   Can you try commenting out the `close_open_libs();` in the destructor and see if that works for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org