You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/11/21 05:58:02 UTC

[GitHub] lixinwen commented on issue #549: Transaction message check back

lixinwen commented on issue #549: Transaction message check back
URL: https://github.com/apache/rocketmq/issues/549#issuecomment-440541908
 
 
   > You are right, set PullStatus.NO_NEW_MSG in this situation is better.
   > But I think set PullStatus.OFFSET_ILLEGAL is also ok. If store#getMessage return OFFSET_OVERFLOW_ONE, the value of pullResult.getNextBeginOffset() is equal to the query offset. So transactionalMessageBridge#updateConsumeOffset just reset the same value, this will not cause offset error.
   
   Yeah, you are right, no serious consequences found at present.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services