You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "dopieralad (via GitHub)" <gi...@apache.org> on 2023/05/11 06:54:01 UTC

[GitHub] [beam] dopieralad opened a new pull request, #26662: Add `BigQueryWrapper` factory method with `PipelineOptions` (#26622)

dopieralad opened a new pull request, #26662:
URL: https://github.com/apache/beam/pull/26662

   This _Pull Request_ addresses issue #26622.
   
   Changes made:
   1. Added factory method to `BigQueryWrapper` that allows for specifying `PipelineOptions` for which the _Google Cloud Platform_ credentials are retrieved for the underlying _BigQuery_ client,
   2. Passed appropriate `PipelineOptions` to `BigQueryWrapper` when estimating _BigQuery_ table size.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [X] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26662:
URL: https://github.com/apache/beam/pull/26662#issuecomment-1554516173

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @riteshghorse for label python.
   R: @Abacn for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26662:
URL: https://github.com/apache/beam/pull/26662#issuecomment-1554595094

   For the Format check fail, run this command to fix:
   
   ```
   # Run from root beam repo dir
   pip install yapf==0.29.0
   git diff HEAD^ --name-only | grep "\.py$" | xargs yapf --in-place
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] dopieralad commented on pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "dopieralad (via GitHub)" <gi...@apache.org>.
dopieralad commented on PR #26662:
URL: https://github.com/apache/beam/pull/26662#issuecomment-1567754773

   I've reformatted the code as you suggested 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26662:
URL: https://github.com/apache/beam/pull/26662#issuecomment-1554595311

   waiting on author


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26662:
URL: https://github.com/apache/beam/pull/26662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26662:
URL: https://github.com/apache/beam/pull/26662#issuecomment-1568485202

   Run Python_Runners PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26662:
URL: https://github.com/apache/beam/pull/26662#issuecomment-1567753879

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#26662](https://app.codecov.io/gh/apache/beam/pull/26662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (77c2b02) into [master](https://app.codecov.io/gh/apache/beam/commit/86f56e92e55e02d2f6586662bebcd907e50dacbe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (86f56e9) will **decrease** coverage by `0.14%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #26662      +/-   ##
   ==========================================
   - Coverage   72.06%   71.93%   -0.14%     
   ==========================================
     Files         745      747       +2     
     Lines      101200   101467     +267     
   ==========================================
   + Hits        72930    72986      +56     
   - Misses      26810    27021     +211     
     Partials     1460     1460              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `80.86% <100.00%> (-0.24%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/26662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/io/gcp/bigquery.py](https://app.codecov.io/gh/apache/beam/pull/26662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `69.74% <100.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/gcp/bigquery\_tools.py](https://app.codecov.io/gh/apache/beam/pull/26662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X3Rvb2xzLnB5) | `74.82% <100.00%> (+0.20%)` | :arrow_up: |
   
   ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/26662/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26662: Use `PipelineOptions` for constructing `BigQueryWrapper` when estimating BigQuery table size (#26622)

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26662:
URL: https://github.com/apache/beam/pull/26662#issuecomment-1570650064

   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org