You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/09/30 19:14:46 UTC
[Impala-ASF-CR] IMPALA-10941: Revert the change for thrift sasl 0.4.3
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17889
Change subject: IMPALA-10941: Revert the change for thrift_sasl 0.4.3
......................................................................
IMPALA-10941: Revert the change for thrift_sasl 0.4.3
A recent patch upgraded thrift_sasl from 0.4.2 to 0.4.3. It broke
the builds on Centos-7. We fixed the build issue by changing
setup.py for thrift_sasl 0.4.3 as work around.
This patch create a temporarily virtualenv prior to the invocation of
python in shell/make_shell_tarball.sh, then upgrade pip and install
up to date setuptools in virtualenv. Remove the virtualenv after
invocation of python code. With this approach, we can revert the
change made for thrift_sasl 0.4.3.
Testing:
- Ran core test on impala-private-parameterized which use Centos-7.
- Ran core test on pre-review-test which use Ubuntu.
Change-Id: I6afba914e182bbb080db045a5af3fc8978ba8d71
---
M shell/ext-py/thrift_sasl-0.4.3/setup.py
M shell/make_shell_tarball.sh
2 files changed, 35 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/17889/2
--
To view, visit http://gerrit.cloudera.org:8080/17889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6afba914e182bbb080db045a5af3fc8978ba8d71
Gerrit-Change-Number: 17889
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10941: Revert the change for thrift sasl 0.4.3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17889 )
Change subject: IMPALA-10941: Revert the change for thrift_sasl 0.4.3
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9536/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6afba914e182bbb080db045a5af3fc8978ba8d71
Gerrit-Change-Number: 17889
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 19:36:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10941: Revert the change for thrift sasl 0.4.3
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has abandoned this change. ( http://gerrit.cloudera.org:8080/17889 )
Change subject: IMPALA-10941: Revert the change for thrift_sasl 0.4.3
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/17889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6afba914e182bbb080db045a5af3fc8978ba8d71
Gerrit-Change-Number: 17889
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>