You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org> on 2026/09/03 18:02:31 UTC
[PR] feat(frontend): render an absent fact as an em dash and a size as 0 B everywhere [texera]
tanishqgandhi1908 opened a new pull request, #8381:
URL: https://github.com/apache/texera/pull/8381
### What changes were proposed in this PR?
A resource's size, and the facts it has none of, rendered four different ways depending on where you looked. This settles on one convention: **a fact with nothing to show renders "—", and a size renders `0 B`**, because zero bytes is a meaningful answer.
**Card view hid the size row; list view showed `0 B`.** A dataset created but never uploaded to showed no size line at all in card view (`*ngIf="size"` hides a zero) and `Size: 0 B` in list view. Card view now always renders the row, so both views agree.
**A copied workflow claimed `Size: 0 B`.** Only search asks the backend for workflow sizes (`SearchService` → `GET /workflow/size`), so a `DashboardEntry` built straight from a duplicate response carried no size and rendered as an empty workflow beside correctly-sized siblings. Both duplicate paths now fetch the sizes before the rows go on screen — the list items read the size once on binding, so filling it in afterwards would not show.
**The two detail cards disagreed with each other.** The dataset Data Card left "Last updated" and "Latest version file" blank; the model Model Card em-dashed them *and* its size. Now both pages em-dash the version facts and both render `0 B` for the size.
`formatSize` is deliberately unchanged.
This is a `feat` rather than a `fix`: it is a deliberate, user-facing change to how these fields render, and it touches the model detail page, which does not exist on the release branches — so it should not be backported.
**Before** — no size line in card view, `0 B` in list view, a fresh copy claiming `0 B`, and the two detail cards disagreeing:
<img width="1440" height="900" alt="issue4-1-datasets-card-view-before" src="https://github.com/user-attachments/assets/5afd125b-f1e3-49b6-b782-6c0657773e9e" />
<img width="1440" height="900" alt="issue4-2-datasets-list-view-before" src="https://github.com/user-attachments/assets/edcca435-c936-4049-8a0b-65d43dfabf71" />
<img width="1440" height="900" alt="issue4-7-duplicated-workflow-before" src="https://github.com/user-attachments/assets/04e02e80-d232-4dec-99bc-35126c4db916" />
<img width="1440" height="900" alt="issue4-3-empty-dataset-stats-before" src="https://github.com/user-attachments/assets/90a00ca4-11a7-428c-88b4-7024899090eb" />
**After** — card view reads `0 B` like list view, the copy reports its real size, and both detail
cards read the same:
<img width="1440" height="900" alt="issue4-1-datasets-card-view-after" src="https://github.com/user-attachments/assets/2d7f4121-b52e-4269-b773-5ba6012e1961" />
<img width="1440" height="900" alt="issue4-7-duplicated-workflow-after" src="https://github.com/user-attachments/assets/2520ff1a-fbb8-4211-b616-32b7086a3946" />
<img width="1440" height="900" alt="issue4-3-empty-dataset-stats-after" src="https://github.com/user-attachments/assets/ace12205-b959-4658-b568-d9be8a89fcef" />
<img width="1440" height="900" alt="issue4-4-empty-model-stats-after" src="https://github.com/user-attachments/assets/496ecdf4-d6d1-459f-9922-c70c6da9b38a" />
### Any related issues, documentation, discussions?
Closes #8380.
### How was this PR tested?
Specs added:
- `card-item.component.spec.ts` — `still reports an empty resource's size, so card and list view
agree`, asserting the row renders and reads `0 B` at size 0. 80 passed.
- `user-workflow.component.spec.ts` — `asks for the copy's size, which the duplicate response does
not carry`, asserting `getSizes` is called with the new wid and the entry takes that size.
74 passed.
- `dataset-detail.component.spec.ts` — `em-dashes the facts a dataset with no versions has none of`
and `shows the real facts once a version exists`, covering both legs of each stat. 144 passed.
- `model-detail.component.spec.ts` — the same case for the model card, pinning "—" for the version
facts and `0 B` for the size. 80 passed.
- `StubWorkflowPersistService` gained a `getSizes` so the duplicate specs exercise the new call.
One existing model spec, `dashes out the latest-version facts for a model with no versions`, asserted
the card contained no `0 B` — it pinned the old model-only convention and is superseded by the new
per-field case, so it was removed rather than edited.
```
cd frontend
npx ng test --include src/app/dashboard/component/user/list-item/card-item/card-item.component.spec.ts
npx ng test --include src/app/dashboard/component/user/user-workflow/user-workflow.component.spec.ts
npx ng test --include src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.spec.ts
npx ng test --include src/app/dashboard/component/user/user-model/user-model-explorer/model-detail.component.spec.ts
```
Checked by hand against a local stack: an empty dataset reads `0 B` in both views, the dataset and
model cards both show `—` for the version facts and `0 B` for the size, and a freshly copied workflow
reports 109.00 B like its siblings instead of 0 B.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): render an absent fact as an em dash and a size as 0 B everywhere [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8381:
URL: https://github.com/apache/texera/pull/8381#issuecomment-5529957314
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`
You can notify them by mentioning `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): render an absent fact as an em dash and a size as 0 B everywhere [texera]
Posted by "aicam (via GitHub)" <gi...@apache.org>.
aicam merged PR #8381:
URL: https://github.com/apache/texera/pull/8381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(frontend): render an absent fact as an em dash and a size as 0 B everywhere [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8381:
URL: https://github.com/apache/texera/pull/8381#issuecomment-5530071553
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8381?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.35294%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 94.03%. Comparing base ([`cd4fd5a`](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e2b43ce`](https://app.codecov.io/gh/apache/texera/commit/e2b43ce72c7f4682c649060c05f8777c18ca3910?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/8381?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...nent/user/user-workflow/user-workflow.component.ts](https://app.codecov.io/gh/apache/texera/pull/8381?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fdashboard%2Fcomponent%2Fuser%2Fuser-workflow%2Fuser-workflow.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9kYXNoYm9hcmQvY29tcG9uZW50L3VzZXIvdXNlci13b3JrZmxvdy91c2VyLXdvcmtmbG93LmNvbXBvbmVudC50cw==) | 75.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/8381?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8381 +/- ##
============================================
- Coverage 94.03% 94.03% -0.01%
Complexity 4771 4771
============================================
Files 1196 1196
Lines 48757 48764 +7
Branches 5916 5919 +3
============================================
+ Hits 45850 45855 +5
- Misses 1458 1459 +1
- Partials 1449 1450 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.89% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.12% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.80% <82.35%> (-0.01%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.47% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [cd4fd5a](https://app.codecov.io/gh/apache/texera/commit/cd4fd5a6d3845f0b7b478e1e86a31bb3151d4cd5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8381?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org