You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "TobiasKiecker (via GitHub)" <gi...@apache.org> on 2024/05/21 10:56:17 UTC
[PR] Fixed TEXT-234 [commons-text]
TobiasKiecker opened a new pull request, #546:
URL: https://github.com/apache/commons-text/pull/546
fixed documentation for setNewLineText, getNewLineText and appendNewLine in both StrBuilder and TextStringBuilder to better reflect their behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed TEXT-234 [commons-text]
Posted by "TobiasKiecker (via GitHub)" <gi...@apache.org>.
TobiasKiecker closed pull request #546: Fixed TEXT-234
URL: https://github.com/apache/commons-text/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed TEXT-234 [commons-text]
Posted by "TobiasKiecker (via GitHub)" <gi...@apache.org>.
TobiasKiecker commented on PR #546:
URL: https://github.com/apache/commons-text/pull/546#issuecomment-2124097262
Looks fine to me, but you just updated StrBuilder (the deprecated class) while TextStringBuilder, which in this aspect is a direct copy, remains unchanged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed TEXT-234 [commons-text]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #546:
URL: https://github.com/apache/commons-text/pull/546#issuecomment-2123340210
Hello @TobiasKiecker
Thank you for your PR.
Please see git master where I updated the Javadoc throughout for this topic.
The wording in some of the changes in this PR felt awkward (to me).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed TEXT-234 [commons-text]
Posted by "TobiasKiecker (via GitHub)" <gi...@apache.org>.
TobiasKiecker commented on PR #546:
URL: https://github.com/apache/commons-text/pull/546#issuecomment-2126433466
I will do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed TEXT-234 [commons-text]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #546:
URL: https://github.com/apache/commons-text/pull/546#issuecomment-2124469357
> Looks fine to me, but you just updated StrBuilder (the deprecated class) while TextStringBuilder, which in this aspect is a direct copy, remains unchanged
Feel free to provide a PR with changes in the same style for other classes 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org