[GitHub] [accumulo] billierinaldi commented on a change in pull request #1450: Fix #1373 Support the init scope in some VolumeChoosers

[GitBox <gi...@apache.org>]

billierinaldi commented on a change in pull request #1450: Fix #1373 Support the init scope in some VolumeChoosers
URL: https://github.com/apache/accumulo/pull/1450#discussion_r355571828
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/InitVolumeChooserEnvironmentImpl.java
 ##########
 @@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.server.fs;
+
+import java.io.IOException;
+
+import org.apache.accumulo.core.conf.AccumuloConfiguration;
+import org.apache.accumulo.core.data.TableId;
+import org.apache.accumulo.core.spi.common.ServiceEnvironment;
+import org.apache.accumulo.server.ServiceEnvironmentImpl;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.Text;
+
+public class InitVolumeChooserEnvironmentImpl implements VolumeChooserEnvironment {
 
 Review comment:
   Thanks for the review, @ctubbsii! I am helping Karthick figure out the changes needed for this issue and your suggestions make sense. Regarding "only override those methods that are necessary," do you mean that we wouldn't need to include the methods that throw UnsupportedOperationException? I was thinking these would be helpful to make it clear which fields have not been initialized for the INIT scope.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services