[jira] Created: (WSRP4J-45) The persistence marshal/unmarshal interfaces in org.apache.wsrp4j.persistence.xml.PersistentDataObjectXML don't do any I/O buffering in the implementation

["Ricky Frost (JIRA)" <ws...@ws.apache.org>]

The persistence marshal/unmarshal interfaces in org.apache.wsrp4j.persistence.xml.PersistentDataObjectXML don't do any I/O buffering in the implementation
----------------------------------------------------------------------------------------------------------------------------------------------------------

         Key: WSRP4J-45
         URL: http://nagoya.apache.org/jira/browse/WSRP4J-45
     Project: WSRP4J
        Type: Improvement
  Components: Persistence  
    Versions: current (nightly)    
 Environment: n/a
    Reporter: Ricky Frost


The interface above has many implementations in the driver package below it, and they all use FileReader and FileWriter in the marshal/unMarshal signatures. That prevents the "dispatch" code in PersistentHandlerImpl from taking advantage of I/O buffering (in one place) by passing BufferedReader and BufferedWriter to the implementations (by just using Reader or Writer in the signatures). Also, all the implementations currently use castor which only needs a Reader or Writer anyway.

Of course, another way to solve the problem would be create the Buffered objects in each impl. But there are 10 impl's and only one dispatch...

Also, I think it's cleaner to just create it at the same time the file is opened and only change the signatures in the implementations... I chose to just change it in the central dispatch code on my system...

The affected files are listed below:

In org.apache.wsrp4j.persistence.xml:
PersistentDataObjectXML (interface signatures only)

In org.apache.wsrp4j.persistence.xml.driver:
PersistentHandlerImpl (this is the "dispatch" - create and pass in the actual BufferedReader and BufferedWriters)
- all remaining files below are - impl signature changes only...
PersistentDataObjectImpl
RegistrationList
PageList
ConsumerConfiguredPortletList
PortletDescriptionList
ConsumerPortletRegistrationList
ConsumerPortletContextList
UserList
PersistentDataObjectImpl
PortletList
ServiceDescriptionList
ProducerList

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira