[jira] Commented: (SHINDIG-321) NameSpace collition in PHP Classes

["Chris Chabot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601496#action_12601496 ] 

Chris Chabot commented on SHINDIG-321:
--------------------------------------

Hey Bruno, quick response while waiting in the philly airport.

I'm 100% ok with renaming Cache for instance, though please follow the internal naming scheme then please (CurrentClassNameScheme) and don't introduce a New_Naming_Scheme please :)

On the email, person, etc ... this departs a lot from the consistency with the java side, right now the POJO names are identical, and i kind of like that the documentation, experience with- & knowledge of is portable between the 2 versions.. 

In general you don't have to pull the social data server (and that's the only bit that would ever instance an 'Person' or 'Name', etc) in your normal name space .. However if your data handler wrapper has to pull in <whatever your implementing it in>'s 'Name' object, yea then i could see that would cause some problems yea :)

How does the java side deal with this potential of name space collision? 

> NameSpace collition in PHP Classes
> ----------------------------------
>
>                 Key: SHINDIG-321
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-321
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Common Components (PHP), Gadget Rendering Server (PHP)
>            Reporter: bruno rovagnati
>         Attachments: namespace_email.patch, namespacer_cache_setpref_setprefs.patch
>
>
> Some classes are having conflicting names such as Cache, Name, Email, Person etc... (mainly src/socialdata/opensocial/model/*)
> I suggest to move those class name to a Shindig_Cache, Shindig_Name, etc. (Zend-like namespace convention)
> i'll start adding patched to these classes that are conflicting while implementing shindig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.