You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/01 05:32:01 UTC

[GitHub] XD-DENG edited a comment on issue #4415: [AIRFLOW-3606] Fix Flake8 test & fix the Flake8 errors introduced since Flake8 test was broken

XD-DENG edited a comment on issue #4415: [AIRFLOW-3606] Fix Flake8 test & fix the Flake8 errors introduced since Flake8 test was broken
URL: https://github.com/apache/incubator-airflow/pull/4415#issuecomment-450710430
 
 
   Hi @ashb , @Fokko , @kaxil , @feng-tao , may any of you have a quick check on this?
   
   **The flake8 test in the Travis CI was broken since https://github.com/apache/incubator-airflow/pull/4361** .
   
   You can refer to this sample commit https://github.com/XD-DENG/incubator-airflow/commit/ba046e3901ae, in which I purposely made some Flake8 errors, while this test still passed with green light (https://travis-ci.org/XD-DENG/incubator-airflow/jobs/474002074). https://github.com/apache/incubator-airflow/pull/4361 actually "turned off" the Flake8 test.
   
   It would be good if we can fix this issue quickly, to avoid any potential Flake8 errors in new PRs to be introduced into master branch.
   
   CC @holdenk who authored https://github.com/apache/incubator-airflow/pull/4361. Please let me know if I misunderstood or missed anything.
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services