You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2026/04/03 11:40:21 UTC
[PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Dandandan opened a new pull request, #21337:
URL: https://github.com/apache/datafusion/pull/21337
## Which issue does this PR close?
N/A - minor optimization
## Rationale for this change
`BooleanArray::has_true()` and `has_false()` (added in arrow 58.1.0) can short-circuit on the first matching value instead of counting all set bits. This is more efficient when only checking for the presence/absence of true/false values.
## What changes are included in this PR?
Replace `true_count() == 0`, `true_count() > 0`, `false_count() == 0`, `true_count() == len`, and `false_count() == len` patterns with `has_true()`/`has_false()` in 6 files where the actual count value is not needed:
- `nested_loop_join.rs` - 2 sites
- `array_has.rs` - 1 site
- `metadata.rs` - 5 sites
- `replace.rs` - 1 site
- `sort_merge_join/filter.rs` - 1 site
- `array_contains.rs` (spark) - 1 site
Cases where the count is used as a value (arithmetic, passed to functions, etc.) are left unchanged.
## Are these changes tested?
Existing tests cover these code paths.
## Are there any user-facing changes?
No.
๐ค Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan closed pull request #21337: Use BooleanArray::has_true/has_false for short-circuit checks
URL: https://github.com/apache/datafusion/pull/21337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21337:
URL: https://github.com/apache/datafusion/pull/21337#issuecomment-4183151415
๐ค Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21337#issuecomment-4183145312)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4183145312-724-49sqj 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing has-true-replace (d53febf54653da964fb9f2541ef5da4b28b84c91) to 1e93a67 (merge-base) [diff](https://github.com/apache/datafusion/compare/1e93a67bd0f24aa9c92a1d0c680410051019eece..d53febf54653da964fb9f2541ef5da4b28b84c91) using: tpch
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21337:
URL: https://github.com/apache/datafusion/pull/21337#issuecomment-4183152687
๐ค Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21337#issuecomment-4183145312)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4183145312-723-cq8j8 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing has-true-replace (d53febf54653da964fb9f2541ef5da4b28b84c91) to 1e93a67 (merge-base) [diff](https://github.com/apache/datafusion/compare/1e93a67bd0f24aa9c92a1d0c680410051019eece..d53febf54653da964fb9f2541ef5da4b28b84c91) using: tpcds
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21337:
URL: https://github.com/apache/datafusion/pull/21337#issuecomment-4183184759
๐ค Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21337#issuecomment-4183145312)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
Comparing HEAD and has-true-replace
--------------------
Benchmark tpch_sf1.json
--------------------
โโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโ
โ Query โ HEAD โ has-true-replace โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 1 โ 45.28 / 45.79 ยฑ0.54 / 46.82 ms โ 45.00 / 47.17 ยฑ1.65 / 49.59 ms โ no change โ
โ QQuery 2 โ 20.88 / 21.13 ยฑ0.17 / 21.38 ms โ 21.19 / 21.37 ยฑ0.26 / 21.87 ms โ no change โ
โ QQuery 3 โ 31.49 / 31.90 ยฑ0.26 / 32.20 ms โ 31.62 / 31.90 ยฑ0.37 / 32.62 ms โ no change โ
โ QQuery 4 โ 20.14 / 21.37 ยฑ0.78 / 22.57 ms โ 20.34 / 21.29 ยฑ0.73 / 22.28 ms โ no change โ
โ QQuery 5 โ 48.35 / 49.46 ยฑ0.94 / 50.81 ms โ 48.45 / 49.58 ยฑ1.67 / 52.91 ms โ no change โ
โ QQuery 6 โ 16.92 / 17.75 ยฑ1.32 / 20.37 ms โ 17.19 / 18.01 ยฑ1.00 / 19.84 ms โ no change โ
โ QQuery 7 โ 54.59 / 55.31 ยฑ0.85 / 56.92 ms โ 54.91 / 55.60 ยฑ0.84 / 57.24 ms โ no change โ
โ QQuery 8 โ 47.40 / 48.13 ยฑ0.45 / 48.66 ms โ 47.32 / 47.95 ยฑ0.61 / 48.70 ms โ no change โ
โ QQuery 9 โ 53.64 / 55.09 ยฑ0.99 / 56.62 ms โ 53.41 / 55.06 ยฑ1.07 / 56.31 ms โ no change โ
โ QQuery 10 โ 70.92 / 72.75 ยฑ2.57 / 77.82 ms โ 72.53 / 73.30 ยฑ0.62 / 74.21 ms โ no change โ
โ QQuery 11 โ 14.00 / 14.60 ยฑ0.80 / 16.18 ms โ 14.13 / 14.50 ยฑ0.52 / 15.53 ms โ no change โ
โ QQuery 12 โ 27.32 / 27.58 ยฑ0.28 / 28.02 ms โ 27.41 / 27.74 ยฑ0.33 / 28.36 ms โ no change โ
โ QQuery 13 โ 38.30 / 39.01 ยฑ0.36 / 39.27 ms โ 38.81 / 39.48 ยฑ0.56 / 40.23 ms โ no change โ
โ QQuery 14 โ 28.08 / 28.47 ยฑ0.22 / 28.76 ms โ 28.61 / 29.11 ยฑ0.44 / 29.87 ms โ no change โ
โ QQuery 15 โ 33.18 / 33.35 ยฑ0.20 / 33.72 ms โ 33.22 / 33.58 ยฑ0.25 / 33.91 ms โ no change โ
โ QQuery 16 โ 15.83 / 16.09 ยฑ0.16 / 16.29 ms โ 16.19 / 16.89 ยฑ0.45 / 17.35 ms โ 1.05x slower โ
โ QQuery 17 โ 73.01 / 74.10 ยฑ1.02 / 75.47 ms โ 74.30 / 75.27 ยฑ0.72 / 76.24 ms โ no change โ
โ QQuery 18 โ 76.74 / 78.55 ยฑ1.92 / 82.13 ms โ 77.02 / 78.83 ยฑ0.97 / 79.87 ms โ no change โ
โ QQuery 19 โ 37.13 / 37.54 ยฑ0.22 / 37.75 ms โ 37.31 / 37.49 ยฑ0.17 / 37.71 ms โ no change โ
โ QQuery 20 โ 39.40 / 40.37 ยฑ0.76 / 41.71 ms โ 39.64 / 41.17 ยฑ1.40 / 43.59 ms โ no change โ
โ QQuery 21 โ 62.76 / 64.11 ยฑ1.19 / 66.04 ms โ 63.77 / 64.80 ยฑ0.88 / 66.00 ms โ no change โ
โ QQuery 22 โ 17.84 / 18.11 ยฑ0.30 / 18.67 ms โ 17.95 / 18.47 ยฑ0.62 / 19.65 ms โ no change โ
โโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 890.56ms โ
โ Total Time (has-true-replace) โ 898.56ms โ
โ Average Time (HEAD) โ 40.48ms โ
โ Average Time (has-true-replace) โ 40.84ms โ
โ Queries Faster โ 0 โ
โ Queries Slower โ 1 โ
โ Queries with No Change โ 21 โ
โ Queries with Failure โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpch โ base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 4.7s |
| Peak memory | 4.0 GiB |
| Avg memory | 3.6 GiB |
| CPU user | 33.5s |
| CPU sys | 2.6s |
| Disk read | 0 B |
| Disk write | 136.0 KiB |
**tpch โ branch**
| Metric | Value |
|--------|-------|
| Wall time | 4.7s |
| Peak memory | 4.1 GiB |
| Avg memory | 3.6 GiB |
| CPU user | 33.6s |
| CPU sys | 2.6s |
| Disk read | 0 B |
| Disk write | 72.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21337:
URL: https://github.com/apache/datafusion/pull/21337#issuecomment-4183201350
๐ค Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21337#issuecomment-4183145312)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
Comparing HEAD and has-true-replace
--------------------
Benchmark tpcds_sf1.json
--------------------
โโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโ
โ Query โ HEAD โ has-true-replace โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 1 โ 42.92 / 44.15 ยฑ0.96 / 45.89 ms โ 42.64 / 43.47 ยฑ0.92 / 45.27 ms โ no change โ
โ QQuery 2 โ 146.00 / 146.82 ยฑ0.72 / 147.84 ms โ 145.82 / 146.71 ยฑ0.57 / 147.51 ms โ no change โ
โ QQuery 3 โ 113.30 / 114.78 ยฑ1.30 / 117.01 ms โ 113.78 / 114.41 ยฑ0.40 / 114.87 ms โ no change โ
โ QQuery 4 โ 1325.87 / 1488.70 ยฑ86.40 / 1565.87 ms โ 1336.94 / 1364.70 ยฑ18.89 / 1386.46 ms โ +1.09x faster โ
โ QQuery 5 โ 173.06 / 175.92 ยฑ2.42 / 179.67 ms โ 173.65 / 174.45 ยฑ0.87 / 176.15 ms โ no change โ
โ QQuery 6 โ 1007.14 / 1055.34 ยฑ31.17 / 1095.35 ms โ 1065.40 / 1107.09 ยฑ35.59 / 1165.09 ms โ no change โ
โ QQuery 7 โ 364.69 / 368.82 ยฑ2.52 / 372.28 ms โ 351.41 / 358.84 ยฑ7.74 / 373.28 ms โ no change โ
โ QQuery 8 โ 117.85 / 119.88 ยฑ1.42 / 121.74 ms โ 116.35 / 117.01 ยฑ0.39 / 117.58 ms โ no change โ
โ QQuery 9 โ 103.95 / 108.00 ยฑ2.04 / 109.39 ms โ 100.41 / 103.88 ยฑ2.86 / 107.76 ms โ no change โ
โ QQuery 10 โ 110.23 / 111.97 ยฑ1.22 / 113.40 ms โ 105.57 / 107.31 ยฑ0.97 / 108.37 ms โ no change โ
โ QQuery 11 โ 975.14 / 1041.19 ยฑ56.62 / 1119.88 ms โ 944.89 / 1032.21 ยฑ66.02 / 1099.26 ms โ no change โ
โ QQuery 12 โ 46.56 / 47.67 ยฑ1.06 / 49.66 ms โ 48.82 / 50.67 ยฑ1.36 / 52.01 ms โ 1.06x slower โ
โ QQuery 13 โ 402.77 / 405.72 ยฑ2.10 / 409.30 ms โ 424.53 / 429.85 ยฑ3.59 / 435.07 ms โ 1.06x slower โ
โ QQuery 14 โ 1054.53 / 1059.44 ยฑ3.38 / 1062.61 ms โ 1022.31 / 1036.75 ยฑ9.91 / 1050.60 ms โ no change โ
โ QQuery 15 โ 16.90 / 17.78 ยฑ0.64 / 18.72 ms โ 16.21 / 17.63 ยฑ1.04 / 18.88 ms โ no change โ
โ QQuery 16 โ 42.07 / 42.86 ยฑ0.99 / 44.56 ms โ 40.38 / 41.28 ยฑ0.63 / 42.30 ms โ no change โ
โ QQuery 17 โ 240.22 / 241.75 ยฑ1.30 / 243.70 ms โ 241.19 / 242.20 ยฑ0.99 / 243.98 ms โ no change โ
โ QQuery 18 โ 129.79 / 130.32 ยฑ0.65 / 131.56 ms โ 127.81 / 129.52 ยฑ1.54 / 132.16 ms โ no change โ
โ QQuery 19 โ 155.07 / 156.61 ยฑ0.95 / 157.88 ms โ 163.33 / 165.52 ยฑ1.73 / 168.03 ms โ 1.06x slower โ
โ QQuery 20 โ 13.65 / 14.34 ยฑ0.49 / 14.95 ms โ 15.26 / 15.69 ยฑ0.48 / 16.33 ms โ 1.09x slower โ
โ QQuery 21 โ 19.38 / 19.97 ยฑ0.44 / 20.51 ms โ 20.70 / 21.05 ยฑ0.27 / 21.41 ms โ 1.05x slower โ
โ QQuery 22 โ 493.13 / 496.74 ยฑ3.52 / 502.66 ms โ 527.74 / 531.77 ยฑ3.17 / 535.30 ms โ 1.07x slower โ
โ QQuery 23 โ 898.86 / 912.89 ยฑ22.96 / 958.60 ms โ 907.28 / 939.48 ยฑ38.48 / 1004.97 ms โ no change โ
โ QQuery 24 โ 438.72 / 441.91 ยฑ2.02 / 444.40 ms โ 414.56 / 417.03 ยฑ2.26 / 421.10 ms โ +1.06x faster โ
โ QQuery 25 โ 375.14 / 377.23 ยฑ2.72 / 382.46 ms โ 356.47 / 358.24 ยฑ0.96 / 359.32 ms โ +1.05x faster โ
โ QQuery 26 โ 83.35 / 85.64 ยฑ1.75 / 88.28 ms โ 81.09 / 82.25 ยฑ0.81 / 83.40 ms โ no change โ
โ QQuery 27 โ 346.12 / 355.95 ยฑ8.20 / 367.56 ms โ 347.41 / 348.97 ยฑ1.65 / 352.06 ms โ no change โ
โ QQuery 28 โ 147.10 / 150.06 ยฑ2.77 / 154.94 ms โ 149.75 / 153.48 ยฑ2.56 / 157.76 ms โ no change โ
โ QQuery 29 โ 296.77 / 300.69 ยฑ2.85 / 304.69 ms โ 314.90 / 316.94 ยฑ1.55 / 318.90 ms โ 1.05x slower โ
โ QQuery 30 โ 44.20 / 45.16 ยฑ0.82 / 46.48 ms โ 45.25 / 48.13 ยฑ1.75 / 50.32 ms โ 1.07x slower โ
โ QQuery 31 โ 171.05 / 173.38 ยฑ2.41 / 177.99 ms โ 178.30 / 181.58 ยฑ1.96 / 183.68 ms โ no change โ
โ QQuery 32 โ 57.29 / 57.97 ยฑ0.82 / 59.48 ms โ 58.48 / 59.93 ยฑ0.92 / 60.98 ms โ no change โ
โ QQuery 33 โ 139.69 / 142.37 ยฑ1.37 / 143.40 ms โ 147.38 / 148.80 ยฑ1.40 / 151.25 ms โ no change โ
โ QQuery 34 โ 106.44 / 107.34 ยฑ0.47 / 107.80 ms โ 113.99 / 115.19 ยฑ1.39 / 117.67 ms โ 1.07x slower โ
โ QQuery 35 โ 107.61 / 108.62 ยฑ0.90 / 110.22 ms โ 114.88 / 116.47 ยฑ1.52 / 118.47 ms โ 1.07x slower โ
โ QQuery 36 โ 211.54 / 216.39 ยฑ3.81 / 221.59 ms โ 212.50 / 219.25 ยฑ5.50 / 227.01 ms โ no change โ
โ QQuery 37 โ 173.85 / 177.37 ยฑ3.00 / 180.86 ms โ 175.26 / 178.29 ยฑ3.68 / 185.50 ms โ no change โ
โ QQuery 38 โ 86.69 / 88.77 ยฑ2.87 / 94.42 ms โ 84.39 / 87.88 ยฑ3.29 / 92.77 ms โ no change โ
โ QQuery 39 โ 126.13 / 128.58 ยฑ1.73 / 131.24 ms โ 124.35 / 128.72 ยฑ2.36 / 131.07 ms โ no change โ
โ QQuery 40 โ 111.86 / 116.01 ยฑ5.57 / 126.85 ms โ 111.70 / 117.22 ยฑ5.12 / 126.24 ms โ no change โ
โ QQuery 41 โ 14.40 / 16.01 ยฑ1.15 / 17.31 ms โ 13.98 / 14.79 ยฑ0.74 / 15.87 ms โ +1.08x faster โ
โ QQuery 42 โ 106.61 / 108.44 ยฑ0.98 / 109.45 ms โ 106.73 / 109.32 ยฑ1.88 / 111.64 ms โ no change โ
โ QQuery 43 โ 83.36 / 84.39 ยฑ1.01 / 86.15 ms โ 83.30 / 84.15 ยฑ0.45 / 84.65 ms โ no change โ
โ QQuery 44 โ 11.94 / 12.45 ยฑ0.47 / 13.06 ms โ 11.86 / 12.16 ยฑ0.34 / 12.67 ms โ no change โ
โ QQuery 45 โ 52.15 / 53.51 ยฑ0.93 / 54.33 ms โ 52.64 / 53.79 ยฑ0.63 / 54.32 ms โ no change โ
โ QQuery 46 โ 231.05 / 232.90 ยฑ1.35 / 234.59 ms โ 231.45 / 232.60 ยฑ0.74 / 233.35 ms โ no change โ
โ QQuery 47 โ 697.46 / 710.60 ยฑ7.91 / 720.55 ms โ 703.30 / 711.37 ยฑ4.69 / 716.36 ms โ no change โ
โ QQuery 48 โ 284.89 / 288.18 ยฑ3.65 / 294.62 ms โ 282.45 / 290.87 ยฑ4.36 / 294.50 ms โ no change โ
โ QQuery 49 โ 255.44 / 260.56 ยฑ4.75 / 267.57 ms โ 255.59 / 257.30 ยฑ1.37 / 259.07 ms โ no change โ
โ QQuery 50 โ 252.76 / 258.00 ยฑ3.45 / 262.77 ms โ 226.53 / 231.44 ยฑ5.88 / 240.61 ms โ +1.11x faster โ
โ QQuery 51 โ 192.30 / 195.49 ยฑ4.03 / 202.61 ms โ 183.73 / 187.00 ยฑ1.65 / 188.14 ms โ no change โ
โ QQuery 52 โ 110.35 / 112.67 ยฑ1.53 / 114.56 ms โ 107.05 / 108.27 ยฑ0.94 / 109.93 ms โ no change โ
โ QQuery 53 โ 105.57 / 106.98 ยฑ1.41 / 109.58 ms โ 102.01 / 103.36 ยฑ1.44 / 106.11 ms โ no change โ
โ QQuery 54 โ 156.34 / 158.69 ยฑ2.37 / 163.07 ms โ 148.10 / 148.84 ยฑ0.91 / 150.33 ms โ +1.07x faster โ
โ QQuery 55 โ 109.60 / 111.86 ยฑ1.94 / 115.25 ms โ 107.49 / 107.90 ยฑ0.33 / 108.32 ms โ no change โ
โ QQuery 56 โ 143.80 / 145.47 ยฑ1.45 / 147.82 ms โ 138.97 / 140.62 ยฑ1.14 / 142.44 ms โ no change โ
โ QQuery 57 โ 177.41 / 180.00 ยฑ2.05 / 183.42 ms โ 175.79 / 177.33 ยฑ1.00 / 178.90 ms โ no change โ
โ QQuery 58 โ 291.81 / 297.17 ยฑ6.87 / 310.42 ms โ 303.17 / 315.78 ยฑ7.73 / 326.92 ms โ 1.06x slower โ
โ QQuery 59 โ 198.96 / 200.88 ยฑ1.85 / 203.39 ms โ 209.45 / 211.54 ยฑ1.42 / 213.43 ms โ 1.05x slower โ
โ QQuery 60 โ 143.30 / 144.44 ยฑ1.28 / 146.52 ms โ 149.55 / 151.48 ยฑ1.38 / 153.74 ms โ no change โ
โ QQuery 61 โ 170.43 / 173.05 ยฑ2.10 / 175.63 ms โ 179.61 / 183.25 ยฑ2.28 / 185.67 ms โ 1.06x slower โ
โ QQuery 62 โ 932.81 / 990.61 ยฑ39.34 / 1034.72 ms โ 920.89 / 995.37 ยฑ53.30 / 1074.65 ms โ no change โ
โ QQuery 63 โ 106.42 / 112.23 ยฑ6.31 / 124.11 ms โ 104.17 / 106.28 ยฑ1.74 / 108.76 ms โ +1.06x faster โ
โ QQuery 64 โ 702.68 / 732.13 ยฑ28.83 / 775.90 ms โ 703.02 / 721.47 ยฑ18.94 / 754.99 ms โ no change โ
โ QQuery 65 โ 250.66 / 265.74 ยฑ13.75 / 285.25 ms โ 284.57 / 285.75 ยฑ1.14 / 287.79 ms โ 1.08x slower โ
โ QQuery 66 โ 253.23 / 265.50 ยฑ11.27 / 284.89 ms โ 254.30 / 262.68 ยฑ5.20 / 270.29 ms โ no change โ
โ QQuery 67 โ 341.80 / 348.87 ยฑ6.55 / 360.20 ms โ 343.73 / 349.31 ยฑ6.10 / 357.43 ms โ no change โ
โ QQuery 68 โ 292.50 / 306.66 ยฑ7.15 / 311.83 ms โ 281.13 / 297.25 ยฑ13.50 / 313.70 ms โ no change โ
โ QQuery 69 โ 101.03 / 102.36 ยฑ1.27 / 104.68 ms โ 102.09 / 103.94 ยฑ1.41 / 105.47 ms โ no change โ
โ QQuery 70 โ 340.05 / 350.20 ยฑ8.28 / 364.69 ms โ 321.60 / 341.61 ยฑ13.39 / 359.96 ms โ no change โ
โ QQuery 71 โ 133.65 / 135.98 ยฑ2.19 / 138.90 ms โ 138.56 / 140.79 ยฑ1.44 / 142.99 ms โ no change โ
โ QQuery 72 โ 698.84 / 715.75 ยฑ12.30 / 729.88 ms โ 770.39 / 778.07 ยฑ6.95 / 791.00 ms โ 1.09x slower โ
โ QQuery 73 โ 102.62 / 104.80 ยฑ2.81 / 110.21 ms โ 102.20 / 106.90 ยฑ3.52 / 112.48 ms โ no change โ
โ QQuery 74 โ 570.67 / 580.94 ยฑ13.25 / 606.77 ms โ 592.13 / 604.73 ยฑ9.55 / 614.87 ms โ no change โ
โ QQuery 75 โ 278.95 / 282.20 ยฑ2.45 / 284.72 ms โ 278.13 / 280.27 ยฑ2.45 / 285.02 ms โ no change โ
โ QQuery 76 โ 137.05 / 139.32 ยฑ1.29 / 140.97 ms โ 133.38 / 134.84 ยฑ1.15 / 136.37 ms โ no change โ
โ QQuery 77 โ 193.72 / 195.91 ยฑ2.27 / 198.71 ms โ 187.66 / 191.18 ยฑ2.66 / 195.22 ms โ no change โ
โ QQuery 78 โ 372.48 / 377.37 ยฑ3.07 / 380.78 ms โ 351.02 / 355.11 ยฑ4.32 / 363.18 ms โ +1.06x faster โ
โ QQuery 79 โ 261.77 / 265.03 ยฑ2.18 / 268.03 ms โ 233.96 / 235.86 ยฑ1.48 / 238.35 ms โ +1.12x faster โ
โ QQuery 80 โ 333.52 / 341.63 ยฑ6.24 / 348.42 ms โ 338.75 / 340.53 ยฑ2.07 / 343.34 ms โ no change โ
โ QQuery 81 โ 26.52 / 27.42 ยฑ0.55 / 28.24 ms โ 28.06 / 29.47 ยฑ0.73 / 30.07 ms โ 1.07x slower โ
โ QQuery 82 โ 198.54 / 201.52 ยฑ2.99 / 205.89 ms โ 202.36 / 205.70 ยฑ1.74 / 207.37 ms โ no change โ
โ QQuery 83 โ 39.27 / 41.32 ยฑ1.93 / 44.89 ms โ 42.68 / 43.52 ยฑ0.89 / 44.90 ms โ 1.05x slower โ
โ QQuery 84 โ 48.56 / 49.42 ยฑ0.77 / 50.66 ms โ 50.78 / 51.46 ยฑ0.57 / 52.38 ms โ no change โ
โ QQuery 85 โ 145.52 / 148.13 ยฑ1.88 / 150.22 ms โ 152.10 / 156.79 ยฑ3.20 / 162.03 ms โ 1.06x slower โ
โ QQuery 86 โ 38.69 / 40.10 ยฑ0.80 / 40.83 ms โ 40.70 / 41.56 ยฑ0.48 / 42.01 ms โ no change โ
โ QQuery 87 โ 83.48 / 88.38 ยฑ4.69 / 96.73 ms โ 95.63 / 99.37 ยฑ4.55 / 108.02 ms โ 1.12x slower โ
โ QQuery 88 โ 99.88 / 100.72 ยฑ1.01 / 102.50 ms โ 103.50 / 105.59 ยฑ1.81 / 108.88 ms โ no change โ
โ QQuery 89 โ 116.16 / 119.47 ยฑ2.14 / 121.81 ms โ 120.40 / 122.45 ยฑ1.83 / 125.34 ms โ no change โ
โ QQuery 90 โ 23.38 / 24.44 ยฑ0.81 / 25.85 ms โ 23.60 / 25.19 ยฑ1.41 / 27.18 ms โ no change โ
โ QQuery 91 โ 62.09 / 65.03 ยฑ1.78 / 67.34 ms โ 65.12 / 66.17 ยฑ0.97 / 67.62 ms โ no change โ
โ QQuery 92 โ 57.67 / 58.58 ยฑ0.63 / 59.38 ms โ 57.30 / 58.40 ยฑ0.69 / 59.30 ms โ no change โ
โ QQuery 93 โ 192.42 / 194.36 ยฑ1.69 / 197.23 ms โ 190.45 / 194.11 ยฑ2.18 / 196.44 ms โ no change โ
โ QQuery 94 โ 60.62 / 61.53 ยฑ0.60 / 62.47 ms โ 61.34 / 62.15 ยฑ0.77 / 63.47 ms โ no change โ
โ QQuery 95 โ 135.92 / 137.30 ยฑ0.92 / 138.28 ms โ 133.05 / 134.31 ยฑ1.01 / 135.36 ms โ no change โ
โ QQuery 96 โ 72.49 / 74.47 ยฑ1.34 / 76.27 ms โ 70.82 / 73.29 ยฑ1.89 / 75.57 ms โ no change โ
โ QQuery 97 โ 129.77 / 132.50 ยฑ1.62 / 134.59 ms โ 130.62 / 132.49 ยฑ1.80 / 135.80 ms โ no change โ
โ QQuery 98 โ 154.18 / 156.17 ยฑ1.42 / 158.60 ms โ 152.63 / 157.12 ยฑ3.27 / 161.63 ms โ no change โ
โ QQuery 99 โ 10856.62 / 10937.97 ยฑ79.73 / 11078.76 ms โ 10797.59 / 10908.50 ยฑ75.37 / 11008.04 ms โ no change โ
โโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 34518.93ms โ
โ Total Time (has-true-replace) โ 34502.62ms โ
โ Average Time (HEAD) โ 348.68ms โ
โ Average Time (has-true-replace) โ 348.51ms โ
โ Queries Faster โ 9 โ
โ Queries Slower โ 19 โ
โ Queries with No Change โ 71 โ
โ Queries with Failure โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**tpcds โ base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 172.9s |
| Peak memory | 5.5 GiB |
| Avg memory | 4.7 GiB |
| CPU user | 278.3s |
| CPU sys | 18.5s |
| Disk read | 0 B |
| Disk write | 638.1 MiB |
**tpcds โ branch**
| Metric | Value |
|--------|-------|
| Wall time | 172.8s |
| Peak memory | 5.9 GiB |
| Avg memory | 4.8 GiB |
| CPU user | 279.8s |
| CPU sys | 18.7s |
| Disk read | 0 B |
| Disk write | 216.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21337:
URL: https://github.com/apache/datafusion/pull/21337#issuecomment-4183200919
๐ค Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21337#issuecomment-4183145312)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
Comparing HEAD and has-true-replace
--------------------
Benchmark clickbench_partitioned.json
--------------------
โโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโ
โ Query โ HEAD โ has-true-replace โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 0 โ 1.30 / 4.56 ยฑ6.42 / 17.41 ms โ 1.33 / 4.66 ยฑ6.52 / 17.71 ms โ no change โ
โ QQuery 1 โ 14.36 / 14.62 ยฑ0.17 / 14.84 ms โ 14.29 / 14.86 ยฑ0.32 / 15.18 ms โ no change โ
โ QQuery 2 โ 43.75 / 43.86 ยฑ0.09 / 43.97 ms โ 43.90 / 44.71 ยฑ0.44 / 45.21 ms โ no change โ
โ QQuery 3 โ 42.68 / 44.35 ยฑ1.17 / 45.87 ms โ 43.21 / 44.92 ยฑ1.10 / 46.54 ms โ no change โ
โ QQuery 4 โ 291.19 / 296.97 ยฑ5.64 / 306.20 ms โ 302.29 / 314.08 ยฑ10.24 / 328.66 ms โ 1.06x slower โ
โ QQuery 5 โ 348.70 / 354.24 ยฑ6.24 / 363.59 ms โ 353.69 / 362.06 ยฑ4.99 / 366.80 ms โ no change โ
โ QQuery 6 โ 5.56 / 7.51 ยฑ2.07 / 10.98 ms โ 5.40 / 6.62 ยฑ1.17 / 8.59 ms โ +1.13x faster โ
โ QQuery 7 โ 16.61 / 19.44 ยฑ5.20 / 29.83 ms โ 17.22 / 18.03 ยฑ0.65 / 18.94 ms โ +1.08x faster โ
โ QQuery 8 โ 421.40 / 444.90 ยฑ15.34 / 468.67 ms โ 435.90 / 453.37 ยฑ13.54 / 476.91 ms โ no change โ
โ QQuery 9 โ 658.54 / 665.77 ยฑ7.10 / 679.30 ms โ 662.69 / 669.04 ยฑ4.43 / 675.69 ms โ no change โ
โ QQuery 10 โ 91.82 / 94.88 ยฑ3.01 / 100.37 ms โ 93.50 / 95.45 ยฑ1.68 / 97.80 ms โ no change โ
โ QQuery 11 โ 104.47 / 105.95 ยฑ1.40 / 108.47 ms โ 105.76 / 107.15 ยฑ0.87 / 108.50 ms โ no change โ
โ QQuery 12 โ 354.36 / 355.77 ยฑ1.06 / 357.18 ms โ 356.08 / 365.22 ยฑ8.21 / 378.49 ms โ no change โ
โ QQuery 13 โ 465.39 / 477.24 ยฑ8.68 / 491.11 ms โ 479.72 / 488.37 ยฑ6.30 / 496.31 ms โ no change โ
โ QQuery 14 โ 361.43 / 365.94 ยฑ3.49 / 370.27 ms โ 362.80 / 365.77 ยฑ1.83 / 367.92 ms โ no change โ
โ QQuery 15 โ 370.69 / 388.23 ยฑ13.72 / 406.59 ms โ 375.55 / 395.04 ยฑ23.26 / 439.04 ms โ no change โ
โ QQuery 16 โ 744.05 / 760.57 ยฑ16.39 / 791.54 ms โ 721.92 / 731.51 ยฑ6.66 / 741.34 ms โ no change โ
โ QQuery 17 โ 737.29 / 741.70 ยฑ5.01 / 751.26 ms โ 747.61 / 782.16 ยฑ31.72 / 833.60 ms โ 1.05x slower โ
โ QQuery 18 โ 1403.08 / 1417.26 ยฑ8.08 / 1425.15 ms โ 1429.55 / 1509.02 ยฑ47.32 / 1564.16 ms โ 1.06x slower โ
โ QQuery 19 โ 36.70 / 38.42 ยฑ0.99 / 39.75 ms โ 35.46 / 36.50 ยฑ1.11 / 38.62 ms โ no change โ
โ QQuery 20 โ 716.12 / 727.15 ยฑ14.14 / 752.09 ms โ 726.37 / 740.53 ยฑ23.67 / 787.58 ms โ no change โ
โ QQuery 21 โ 765.10 / 769.77 ยฑ2.86 / 773.64 ms โ 769.81 / 778.46 ยฑ11.96 / 801.40 ms โ no change โ
โ QQuery 22 โ 1147.57 / 1151.90 ยฑ4.44 / 1160.03 ms โ 1142.16 / 1146.67 ยฑ3.42 / 1151.15 ms โ no change โ
โ QQuery 23 โ 3073.70 / 3112.01 ยฑ28.02 / 3151.86 ms โ 3059.13 / 3089.13 ยฑ15.84 / 3103.52 ms โ no change โ
โ QQuery 24 โ 99.29 / 103.94 ยฑ3.98 / 109.80 ms โ 99.28 / 102.05 ยฑ2.09 / 105.35 ms โ no change โ
โ QQuery 25 โ 138.75 / 140.23 ยฑ1.32 / 142.55 ms โ 137.60 / 140.24 ยฑ2.46 / 144.18 ms โ no change โ
โ QQuery 26 โ 102.92 / 104.32 ยฑ1.17 / 106.38 ms โ 101.76 / 104.10 ยฑ1.90 / 106.40 ms โ no change โ
โ QQuery 27 โ 849.50 / 858.74 ยฑ7.22 / 867.33 ms โ 853.41 / 856.81 ยฑ3.58 / 863.20 ms โ no change โ
โ QQuery 28 โ 7715.56 / 7800.37 ยฑ43.41 / 7832.93 ms โ 7722.61 / 7795.61 ยฑ42.06 / 7845.90 ms โ no change โ
โ QQuery 29 โ 52.47 / 55.98 ยฑ3.33 / 60.87 ms โ 50.48 / 55.51 ยฑ4.63 / 63.41 ms โ no change โ
โ QQuery 30 โ 368.97 / 376.25 ยฑ4.94 / 382.74 ms โ 362.66 / 369.74 ยฑ4.82 / 374.27 ms โ no change โ
โ QQuery 31 โ 375.95 / 398.09 ยฑ16.94 / 427.66 ms โ 383.04 / 390.82 ยฑ6.77 / 402.02 ms โ no change โ
โ QQuery 32 โ 1045.57 / 1058.52 ยฑ13.24 / 1081.42 ms โ 1047.56 / 1066.08 ยฑ32.49 / 1130.98 ms โ no change โ
โ QQuery 33 โ 1501.70 / 1510.79 ยฑ5.53 / 1517.20 ms โ 1490.29 / 1508.66 ยฑ14.10 / 1525.33 ms โ no change โ
โ QQuery 34 โ 1504.06 / 1520.73 ยฑ10.80 / 1536.37 ms โ 1471.06 / 1488.10 ยฑ17.60 / 1521.36 ms โ no change โ
โ QQuery 35 โ 410.95 / 415.60 ยฑ4.98 / 423.66 ms โ 382.54 / 389.85 ยฑ4.14 / 394.80 ms โ +1.07x faster โ
โ QQuery 36 โ 115.87 / 124.17 ยฑ5.37 / 130.88 ms โ 124.48 / 126.39 ยฑ1.32 / 128.34 ms โ no change โ
โ QQuery 37 โ 50.30 / 51.60 ยฑ1.28 / 53.81 ms โ 47.54 / 50.95 ยฑ2.33 / 53.28 ms โ no change โ
โ QQuery 38 โ 75.40 / 77.71 ยฑ1.43 / 79.75 ms โ 77.16 / 78.44 ยฑ0.75 / 79.51 ms โ no change โ
โ QQuery 39 โ 213.77 / 225.23 ยฑ8.24 / 234.09 ms โ 209.66 / 219.04 ยฑ7.61 / 231.74 ms โ no change โ
โ QQuery 40 โ 23.98 / 26.70 ยฑ3.02 / 31.61 ms โ 25.92 / 27.45 ยฑ1.99 / 31.05 ms โ no change โ
โ QQuery 41 โ 20.86 / 21.76 ยฑ0.84 / 23.24 ms โ 19.44 / 20.88 ยฑ1.19 / 23.03 ms โ no change โ
โ QQuery 42 โ 20.62 / 21.07 ยฑ0.36 / 21.64 ms โ 19.32 / 19.75 ยฑ0.44 / 20.60 ms โ +1.07x faster โ
โโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 27294.80ms โ
โ Total Time (has-true-replace) โ 27373.81ms โ
โ Average Time (HEAD) โ 634.76ms โ
โ Average Time (has-true-replace) โ 636.60ms โ
โ Queries Faster โ 4 โ
โ Queries Slower โ 3 โ
โ Queries with No Change โ 36 โ
โ Queries with Failure โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโ
```
</p>
</details>
<details><summary>Resource Usage</summary>
**clickbench_partitioned โ base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 137.6s |
| Peak memory | 41.6 GiB |
| Avg memory | 33.8 GiB |
| CPU user | 1304.0s |
| CPU sys | 84.6s |
| Disk read | 0 B |
| Disk write | 5.2 GiB |
**clickbench_partitioned โ branch**
| Metric | Value |
|--------|-------|
| Wall time | 138.1s |
| Peak memory | 42.1 GiB |
| Avg memory | 30.8 GiB |
| CPU user | 1298.8s |
| CPU sys | 90.9s |
| Disk read | 0 B |
| Disk write | 120.0 KiB |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #21337:
URL: https://github.com/apache/datafusion/pull/21337#issuecomment-4183152939
๐ค Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21337#issuecomment-4183145312)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4183145312-722-7hz62 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing has-true-replace (d53febf54653da964fb9f2541ef5da4b28b84c91) to 1e93a67 (merge-base) [diff](https://github.com/apache/datafusion/compare/1e93a67bd0f24aa9c92a1d0c680410051019eece..d53febf54653da964fb9f2541ef5da4b28b84c91) using: clickbench_partitioned
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Use BooleanArray::has_true/has_false for short-circuit checks [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #21337:
URL: https://github.com/apache/datafusion/pull/21337#issuecomment-4183145312
run benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org