You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/26 18:25:26 UTC
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 opened a new pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
xiaoxiang781216 opened a new pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72
## Summary
To fix the issue: #2094
## Impact
The automation build
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#discussion_r513209453
##########
File path: testlist/other.dat
##########
@@ -0,0 +1,28 @@
+# We do not have a toolchain for avr32 outside of Microchip login wall.
+# The work was never upstreamed to GCC.
+
+/avr
+-avr32dev1:nsh
+-avr32dev1:ostest
+
+/renesas/rx65n/rx65n-grrose
+-rx65n-grrose:ipv6
+
+/renesas/rx65n/rx65n-rsk2mb
+-rx65n-rsk2mb:ipv6
+
+# PINGUINOL toolchain doesn't provide macOS binaries
+# with the same name
+# /mips,CONFIG_MIPS32_TOOLCHAIN_PINGUINOL
+
+/risc-v,CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
+-gapuino:nsh
+-nr5m100-nexys4:nsh
+
+# x86_64-elf-gcc from homebrew doesn't seem to
+# provide __udivdi3 etc for -m32
+# /x86
Review comment:
Done, I move this change to another PR.
##########
File path: testlist/sim.dat
##########
@@ -3,12 +3,14 @@
# CONFIG_SIM_M32=y
# The recent versions of macOS is 64-bit only
--sim:loadable
--sim:module32
--sim:sotest32
+-sim:loadable,Darwin
+-sim:module32,Darwin
+-sim:rpproxy,Darwin
+-sim:rpserver,Darwin
+-sim:sotest32,Darwin
# X11
-# macOS doesn't have X11
+# macOS/Docker doesn't have X11
Review comment:
Done.
##########
File path: testlist/sim.dat
##########
@@ -3,12 +3,14 @@
# CONFIG_SIM_M32=y
# The recent versions of macOS is 64-bit only
--sim:loadable
--sim:module32
--sim:sotest32
+-sim:loadable,Darwin
+-sim:module32,Darwin
+-sim:rpproxy,Darwin
+-sim:rpserver,Darwin
+-sim:sotest32,Darwin
# X11
-# macOS doesn't have X11
+# macOS/Docker doesn't have X11
Review comment:
So, I can enable it now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#issuecomment-716742918
Can we consider what I did in this PR instead #71 I find to easier to have the restrictions for an arch in a single file rather than mixed with all the targets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 edited a comment on pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#issuecomment-716759923
> Can we consider what I did in this PR instead #71 I find to easier to have the restrictions for an host in a single file rather than mixed with all the targets.
But puting all blacklist in one place give us the whole picture and the difference between host quickly.
> It would also make it easier to have modifiers a for a host added later.
I am thinking to change blacklist to regex pattern instead using config as regex, then we don't need change the match anymore and write the complex parttern, e.g.: -sim:nsh,(Linux)|(Darwin).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#discussion_r513207877
##########
File path: testlist/sim.dat
##########
@@ -3,12 +3,14 @@
# CONFIG_SIM_M32=y
# The recent versions of macOS is 64-bit only
--sim:loadable
--sim:module32
--sim:sotest32
+-sim:loadable,Darwin
+-sim:module32,Darwin
+-sim:rpproxy,Darwin
+-sim:rpserver,Darwin
+-sim:sotest32,Darwin
# X11
-# macOS doesn't have X11
+# macOS/Docker doesn't have X11
Review comment:
Dockerfile shows
```
libx11-dev:i386 \
libxext-dev:i386 \
```
I think these targets should build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#issuecomment-716759923
> Can we consider what I did in this PR instead #71 I find to easier to have the restrictions for an host in a single file rather than mixed with all the targets.
But puting all blacklist in one place give us the whole picture and the difference between host quickly.
> It would also make it easier to have modifiers a for a host added later.
I am thinking to change blacklist to regex pattern instead using config as regex, then we don't need change the match anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#discussion_r513206117
##########
File path: testlist/other.dat
##########
@@ -0,0 +1,28 @@
+# We do not have a toolchain for avr32 outside of Microchip login wall.
+# The work was never upstreamed to GCC.
+
+/avr
+-avr32dev1:nsh
+-avr32dev1:ostest
+
+/renesas/rx65n/rx65n-grrose
+-rx65n-grrose:ipv6
+
+/renesas/rx65n/rx65n-rsk2mb
+-rx65n-rsk2mb:ipv6
+
+# PINGUINOL toolchain doesn't provide macOS binaries
+# with the same name
+# /mips,CONFIG_MIPS32_TOOLCHAIN_PINGUINOL
+
+/risc-v,CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
+-gapuino:nsh
+-nr5m100-nexys4:nsh
+
+# x86_64-elf-gcc from homebrew doesn't seem to
+# provide __udivdi3 etc for -m32
+# /x86
Review comment:
We should be able to re-enable this now with the Darwin exception.
##########
File path: testlist/sim.dat
##########
@@ -3,12 +3,14 @@
# CONFIG_SIM_M32=y
# The recent versions of macOS is 64-bit only
--sim:loadable
--sim:module32
--sim:sotest32
+-sim:loadable,Darwin
+-sim:module32,Darwin
+-sim:rpproxy,Darwin
+-sim:rpserver,Darwin
+-sim:sotest32,Darwin
# X11
-# macOS doesn't have X11
+# macOS/Docker doesn't have X11
Review comment:
Not for this PR, but I'll get the X11 headers added to the docker image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] jerpelea merged pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#issuecomment-717750397
Merged OS side, just restarted the build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton edited a comment on pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #72:
URL: https://github.com/apache/incubator-nuttx-testing/pull/72#issuecomment-716742918
Can we consider what I did in this PR instead #71 I find to easier to have the restrictions for an host in a single file rather than mixed with all the targets. It would also make it easier to have modifiers a for a host added later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org