You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2014/03/06 23:35:44 UTC

[Bug 56228] New: View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

            Bug ID: 56228
           Summary: View Results Tree : Improve ergonomy by changing
                    placement of Renderers and allowing custom ordering
           Product: JMeter
           Version: 2.11
          Hardware: Other
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: p.mouawad@ubik-ingenierie.com

As per mailing list discussion:
http://mail-archives.apache.org/mod_mbox/jmeter-dev/201403.mbox/%3CCAH9fUpbhfkSo6d4M6v7Xn2KJnwqq-2Gh0v_num63Rt3TrUnJkQ%40mail.gmail.com%3E

Discussion excerpt:
Philippe M. proposal
    *View Results Tree:*
    - I feel  the select box at the bottom left of component allowing selection
    of a Viewer is misplaced. I often switch between Viewers during scripting
    and I think it should a Tabbed Pane on the Top Center Right Part of View
    Results Tree or something better if you have ideas.  This would make it
    more visible and allow easy switching. Currently you lose a lot of time
    switching and finding the right component
    I also think we should at least change their display priority, I tend to
    think it should be something like
    - Text
    - Regexp Tester
    - CSS / JQUERY Test
    - XPATH Tester
    - HTML
    - HTML (download) => Very annoying that it blocks screen to download
    resource
    - Document
    - JSON => Not very useful currently
    - XML  => Do you use it ?

Milamber note:
Yes it's a good idea to change order. Except perhaps Text plain view, the order
for others renderers can be different in function of situation.
Perhaps, introduce a property for ordering the renderers?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56228] View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Mon Mar 10 22:34:31 2014
New Revision: 1576110

URL: http://svn.apache.org/r1576110
Log:
Bug 56228 - View Results Tree : Improve ergonomy by changing placement of
Renderers and allowing custom ordering
Bugzilla Id: 56228

Modified:
    jmeter/trunk/bin/jmeter.properties
   
jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56228] View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Created attachment 31373
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31373&action=edit
Proposal

New property introduced which controls order:
view.results.tree.renderers_order=org.apache.jmeter.visualizers.RenderAsText,org.apache.jmeter.visualizers.RenderAsRegexp,org.apache.jmeter.visualizers.RenderAsCssJQuery,org.apache.jmeter.visualizers.RenderAsXPath,org.apache.jmeter.visualizers.RenderAsHTML,org.apache.jmeter.visualizers.RenderAsHTMLWithEmbedded,org.apache.jmeter.visualizers.RenderAsDocument,org.apache.jmeter.visualizers.RenderAsJSON,org.apache.jmeter.visualizers.RenderAsXML,com.ubikingenierie.loadpack.json.render.RenderJsonAsXML,com.ubikingenierie.loadpack.json.render.RenderAsJsonRenderer,com.ubikingenierie.loadpack.json.render.RenderJsonAsXML,com.ubikingenierie.loadpack.json.render.RenderAsJsonRenderer

Note renderers not mentionned in list will be added after those mentionned to
handle correctly plugins or errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56228] View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
These are plugins, forget about them, they will not be included.

Otherwise shall I commit this ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56228] View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

--- Comment #3 from Sebb <se...@apache.org> ---
(In reply to Philippe Mouawad from comment #1)
...

> com.ubikingenierie.loadpack.json.render.RenderJsonAsXML,com.
> ubikingenierie.loadpack.json.render.RenderAsJsonRenderer,com.ubikingenierie.
> loadpack.json.render.RenderJsonAsXML,com.ubikingenierie.loadpack.json.render.
> RenderAsJsonRenderer

Why are these classes not in the JMeter package structure?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56228] View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Created attachment 31374
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31374&action=edit
Patch proposal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56228] View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Ok, I will implement and commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56228] View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56228

--- Comment #5 from Sebb <se...@apache.org> ---
The list is quite awkward to read.

I suggest allowing a shorthand - instead of 

org.apache.jmeter.visualizers.RenderAsText

one could use

.RenderAsText

i.e. if the class name starts with "." (which is not valid) then prepend

org.apache.jmeter.visualizers

-- 
You are receiving this mail because:
You are the assignee for the bug.