[GitHub] [spark] cloud-fan commented on a diff in pull request #37415: [SPARK-40020][SQL] Centralize the code of qualifying identifiers in SessionCatalog

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37415:
URL: https://github.com/apache/spark/pull/37415#discussion_r941435240


##########
sql/core/src/test/resources/sql-tests/results/describe.sql.out:
##########
@@ -552,7 +552,7 @@ struct<plan:string>
 -- !query output
 == Physical Plan ==
 Execute DescribeTableCommand
-   +- DescribeTableCommand `spark_catalog`.`default`.`t`, false, [col_name#x, data_type#x, comment#x]
+   +- DescribeTableCommand `default`.`t`, false, [col_name#x, data_type#x, comment#x]

Review Comment:
   This reverts back to the behavior before https://github.com/apache/spark/pull/37021 . We only want to attach the v1 catalog name in some command output and error messages. Qualifying the identifiers in every v1 command is a different story: it's non-trivial as we need to follow the v2 command framework and look up the identifiers to see if it's a temp view or persistent tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org