[jira] [Commented] (KAFKA-3850) WorkerSinkTask should retry commits if woken up during rebalance or shutdown

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332963#comment-15332963 ] 

ASF GitHub Bot commented on KAFKA-3850:
---------------------------------------

Github user hachikuji closed the pull request at:

    https://github.com/apache/kafka/pull/1511


> WorkerSinkTask should retry commits if woken up during rebalance or shutdown
> ----------------------------------------------------------------------------
>
>                 Key: KAFKA-3850
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3850
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.10.0.0
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For: 0.10.0.1
>
>
> We use consumer.wakeup() to interrupt long polls when we need to pause/resume partitions and when we shutdown sink tasks. The resulting {{WakeupException}} could be raised from the synchronous commit which we use in between rebalances and on shutdown. Since we don't currently catch this exception, we can fail to commit offsets, which typically results in duplicates. To fix this problem, we should catch the exception, retry the commit, and then rethrow it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)