You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "henrymai (via GitHub)" <gi...@apache.org> on 2023/07/28 19:33:36 UTC
[GitHub] [spark] henrymai opened a new pull request, #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
henrymai opened a new pull request, #42214:
URL: https://github.com/apache/spark/pull/42214
### What changes were proposed in this pull request?
Fix double encryption issue for migrated shuffle blocks
Shuffle blocks upon migration are sent without decryption when io.encryption is enabled. The code on the receiving side ends up using serializer.wrapForEncryption on the OutputStream to the file which results in the already encrypted bytes being encrypted again when the bytes are written out.
This patch removes the usage of serializerManager.wrapForEncryption on the receiving side and also adds tests that validate that this works as expected. I have also validated that the added tests will fail if the fix is not in place.
### Why are the changes needed?
Migrated shuffle blocks will be double encrypted when `spark.io.encryption = true` without this fix.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests were added to explicitly enable spark.io.encryption and to also properly construct the SerializerManager with the encryption key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] henrymai commented on pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "henrymai (via GitHub)" <gi...@apache.org>.
henrymai commented on PR #42214:
URL: https://github.com/apache/spark/pull/42214#issuecomment-1661172289
@dongjoon-hyun
Here are the backports:
https://github.com/apache/spark/pull/42277
https://github.com/apache/spark/pull/42279
As I mentioned on the 3.4 one, not sure why appveyor is saying it can't be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
URL: https://github.com/apache/spark/pull/42214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42214:
URL: https://github.com/apache/spark/pull/42214#issuecomment-1661141004
In addition, welcome to the Apache Spark community, @henrymai .
I added you to the Apache Spark contributor group and assign SPARK-44588 to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42214:
URL: https://github.com/apache/spark/pull/42214#issuecomment-1661136858
Thank you, @henrymai .
Merged to master/3.5.
There is a conflict in branch-3.4 and older. Could you make two backporting PRs for branch-3.4 and branch-3.3 separately, @henrymai ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42214:
URL: https://github.com/apache/spark/pull/42214#issuecomment-1661237048
Thank you, @henrymai .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #42214:
URL: https://github.com/apache/spark/pull/42214#issuecomment-1657694332
+CC @holdenk, @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] henrymai commented on pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "henrymai (via GitHub)" <gi...@apache.org>.
henrymai commented on PR #42214:
URL: https://github.com/apache/spark/pull/42214#issuecomment-1661143305
> Thank you, @henrymai .
>
> Merged to master/3.5.
>
> There is a conflict in branch-3.4 and older. Could you make two backporting PRs for branch-3.4 and branch-3.3 separately, @henrymai ?
Will do. Thanks for merging this in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42214: [SPARK-44588][CORE] Fix double encryption issue for migrated shuffle blocks
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42214:
URL: https://github.com/apache/spark/pull/42214#issuecomment-1661123353
Thank you for pinging me, @mridulm .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org