You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/30 22:30:10 UTC

[GitHub] [pulsar] lin-zhao commented on pull request #17320: [fix][doc] Add more information for producer_request_hold policy

lin-zhao commented on PR #17320:
URL: https://github.com/apache/pulsar/pull/17320#issuecomment-1232235444

   > According to the `BacklogQuotaManager`'s logic here: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java#L104-L107 I think the behavior should be broker disconnect producer when it detect backlog quota exceeded, and producer will get `ProducerBlockedQuotaExceededError` which is retryable, so it'll keep reconnecting till backlog is cleared: https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L1759-L1762 So no data will be send to broker in such base and producer is hold the data till backlog is cleared. Will let Jiwei confirm.
   
   You are exactly right. This is the right logic for this policy. Though I think the documentation for the policy should be really concise without all the details behind the scene.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org