You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/14 09:43:10 UTC
[GitHub] [maven-fluido-skin] michael-o opened a new pull request, #30: Refinement
michael-o opened a new pull request, #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30
@kwin Here is another try. This fits now into the sidebar, but will also narrow it for the topbar. I think those 7 percert are acceptable for the topbar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] asfgit closed pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #30: Refinement
URL: https://github.com/apache/maven-fluido-skin/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126735055
> I don't think you get centered alignment with just width in percentage. This is due to the fact that the margins of the sidebar are fix, while the column overall is responsive, i.e. for very wide browser windows even with this PR the search input is misaligned and the left margin is much wider than the fix right one. 
I agree. Therefore, I likely need to revert my previous commit and leave the ticket open. My CSS knowledge is to weak in this regard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126738318
Maybe 28px is not correct.
The important metrics are:
margin-right and left: 9px and border-radius: 15px
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126737458
Yes, this is what I thought too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126736331
> Where do those 28px come from?
Right and left margin of 14px in the sidebar. One could even restrict that width to only inside the sidebar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] asfgit merged pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126735233
I just tried `width: calc(100% - 28px);` and this worked fine. Look also at https://stackoverflow.com/questions/17631611/100-width-minus-margin-and-padding and https://caniuse.com/calc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126736139
> I just tried `width: calc(100% - 28px);` and this worked fine. Look also at https://stackoverflow.com/questions/17631611/100-width-minus-margin-and-padding and https://caniuse.com/calc.
Where do those 28px come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126739220
Looks like `30px` = 2 x border-radius is the correct value to subtract here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126736545
> > Where do those 28px come from?
>
> Right and left margin of 14px in the sidebar. One could even restrict that width to only inside the sidebar.
Double check when this search bar is in the top bar. Physics change there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126737255
You can easily restrict `width: calc(100% - 28px);` to only sidebar with a selector like `.sidebar-nav input.search-query`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #30: Refinement
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #30:
URL: https://github.com/apache/maven-fluido-skin/pull/30#issuecomment-1126734185
I don't think you get centered alignment with just width in percentage. This is due to the fact that the margins of the sidebar are fix, while the column overall is responsive, i.e. for very wide browser windows even with this PR the search input is misaligned and the left margin is much wider than the fix right one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org