[jira] [Commented] (ACCUMULO-4573) Writing a correct compaction strategy is difficult.

["Michael Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888564#comment-15888564 ] 

Michael Miller commented on ACCUMULO-4573:
------------------------------------------

What kind of change do you have in mind?  Something like changing the way Tablet calls shouldCompact?
{code}
org/apache/accumulo/tserver/tablet/Tablet.java:
if (strategy.shouldCompact(request)) {
          initiateMajorCompaction(MajorCompactionReason.USER);
{code}

> Writing a correct compaction strategy is difficult.
> ---------------------------------------------------
>
>                 Key: ACCUMULO-4573
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4573
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.6, 1.7.2, 1.8.0
>            Reporter: Keith Turner
>
> Compaction strategies have two methods that are not supposed to block.  If someone does write a strategy that blocks, it can cause scans to block.   Even though its documents in the javadoc, this very tricky to get right.  Would be better to change interaction so that its not harmful if strategy blocks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)