[GitHub] Ben-Zvi opened a new pull request #1546: DRILL-6861: Hash-Join should not exit after an empty probe-side spilled partition

[GitBox <gi...@apache.org>]

Ben-Zvi opened a new pull request #1546: DRILL-6861: Hash-Join should not exit after an empty probe-side spilled partition
URL: https://github.com/apache/drill/pull/1546
 
 
   (The DIFF below is excessive due to indentation; but only two "lines" where actually changed).
   
   The original code below handles the spilled partitions by getting the next one (as build+probe "incoming"), and then recursively calling *innerNext()*.  Each recursive call would end by (recursively) processing the next spilled partition.
   
      The DRILL-6755 change (line 556) caused an early exit when the probe side was empty. Thus in special cases when a probe-side of a spilled partition was empty, this change would terminate the recursive chain early, thus not processing the remaining partitions.
   
      The fix: When an empty probe-side spilled partition is seen - skip and process the next partition. A new check was added (line 624), and the code was altered into a "while" loop (line 618) to allow skipping. 
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services