You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/12/02 09:21:53 UTC
[GitHub] cloudstack pull request: debian: allow rules to pick ACS_BUILD_OPT...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1149
debian: allow rules to pick ACS_BUILD_OPTS from env
Only now debian builds can be noredist etc.
cc @remibergsma @wido - I think the apt-get.eu 4.6.0 deb repo was oss and not noredist one. I also checked the jenkins job it does not "export ACS_BUILD_OPTS='-Dnoredist -Dnonoss'" before running dpkg-buildpackage
I discovered this while testing 4.6.1 RC1 today, nothing major just a build profile issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 4.6-debian-noredist-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1149
----
commit 433a79f989a51f88713b130cd51182373139577e
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-12-02T08:15:18Z
debian: allow rules to pick ACS_BUILD_OPTS from env
Only now debian builds can be noredist etc.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161709051
Seems good, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161748134
@bhaisaab Should I merge this to master, or should it be merged to 4.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161429236
Makes sense, LGTM also based on the successful job above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161885184
@bhaisaab Check! This I cannot merge to 4.6 with this PR so if you make one against 4.6 that would be easy. Mention this one so it can go through faster. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161898597
@remibergsma thanks, opened another PR #1169 please merge that. Closing this one, as once the other PR will be merged on 4.6 and 4.6 on master; we won't need this PR anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161216838
Test jenkins build job: http://sb.bhaisaab.org:8888/job/deb-shapeblue-build-patch-noredist/103/console
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161878014
@remibergsma let me know if you want me to open a new PR against 4.6 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161437830
Ping @borisroman to have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161877977
@remibergsma sorry for the source/target branches; this needs to go into both 4.6 and master branches. So merge on 4.6, and fwd-merge 4.6 on master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---