You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Stefan Gmeiner (Created) (JIRA)" <ji...@apache.org> on 2012/02/17 07:55:59 UTC
[jira] [Created] (THRIFT-1516) TProtocolException in C# should be
public
TProtocolException in C# should be public
-----------------------------------------
Key: THRIFT-1516
URL: https://issues.apache.org/jira/browse/THRIFT-1516
Project: Thrift
Issue Type: Bug
Components: C# - Library
Affects Versions: 0.8
Reporter: Stefan Gmeiner
Priority: Minor
The TProtocolException in the C# lib has no access modifier which results in internal access restriction. This makes it impossible to create or catch such a exception by client code if for example you want to implement a custom protocol. In the Java lib this exception for example is declared public.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1516) TProtocolException in C# should be
public
Posted by "Stefan Gmeiner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212473#comment-13212473 ]
Stefan Gmeiner commented on THRIFT-1516:
----------------------------------------
Patch added.
> TProtocolException in C# should be public
> -----------------------------------------
>
> Key: THRIFT-1516
> URL: https://issues.apache.org/jira/browse/THRIFT-1516
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.8
> Reporter: Stefan Gmeiner
> Priority: Minor
> Attachments: THRIFT-1516.patch
>
>
> The TProtocolException in the C# lib has no access modifier which results in internal access restriction. This makes it impossible to create or catch such a exception by client code if for example you want to implement a custom protocol. In the Java lib this exception for example is declared public.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1516) TProtocolException in C# should be
public
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213446#comment-13213446 ]
Hudson commented on THRIFT-1516:
--------------------------------
Integrated in Thrift #408 (See [https://builds.apache.org/job/Thrift/408/])
THRIFT-1516 TProtocolException in C# should be public
Patch: Stefan Gmeiner (Revision 1292148)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1292148
Files :
* /thrift/trunk/lib/csharp/src/Protocol/TProtocolException.cs
> TProtocolException in C# should be public
> -----------------------------------------
>
> Key: THRIFT-1516
> URL: https://issues.apache.org/jira/browse/THRIFT-1516
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.8
> Reporter: Stefan Gmeiner
> Priority: Minor
> Attachments: THRIFT-1516.patch
>
>
> The TProtocolException in the C# lib has no access modifier which results in internal access restriction. This makes it impossible to create or catch such a exception by client code if for example you want to implement a custom protocol. In the Java lib this exception for example is declared public.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1516) TProtocolException in C# should be
public
Posted by "Stefan Gmeiner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Gmeiner updated THRIFT-1516:
-----------------------------------
Attachment: THRIFT-1516.patch
> TProtocolException in C# should be public
> -----------------------------------------
>
> Key: THRIFT-1516
> URL: https://issues.apache.org/jira/browse/THRIFT-1516
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.8
> Reporter: Stefan Gmeiner
> Priority: Minor
> Attachments: THRIFT-1516.patch
>
>
> The TProtocolException in the C# lib has no access modifier which results in internal access restriction. This makes it impossible to create or catch such a exception by client code if for example you want to implement a custom protocol. In the Java lib this exception for example is declared public.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1516) TProtocolException in C# should be
public
Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1516.
---------------------------------
Resolution: Fixed
Thanks Stefan, committed.
> TProtocolException in C# should be public
> -----------------------------------------
>
> Key: THRIFT-1516
> URL: https://issues.apache.org/jira/browse/THRIFT-1516
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.8
> Reporter: Stefan Gmeiner
> Priority: Minor
> Attachments: THRIFT-1516.patch
>
>
> The TProtocolException in the C# lib has no access modifier which results in internal access restriction. This makes it impossible to create or catch such a exception by client code if for example you want to implement a custom protocol. In the Java lib this exception for example is declared public.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1516) TProtocolException in C# should be
public
Posted by "Roger Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211479#comment-13211479 ]
Roger Meier commented on THRIFT-1516:
-------------------------------------
Agree, could you provide a patch?
> TProtocolException in C# should be public
> -----------------------------------------
>
> Key: THRIFT-1516
> URL: https://issues.apache.org/jira/browse/THRIFT-1516
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.8
> Reporter: Stefan Gmeiner
> Priority: Minor
>
> The TProtocolException in the C# lib has no access modifier which results in internal access restriction. This makes it impossible to create or catch such a exception by client code if for example you want to implement a custom protocol. In the Java lib this exception for example is declared public.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira