You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Denis Pokataev <ca...@cpan.org> on 2008/10/19 13:36:11 UTC
[PATCH] Issue 3272 ( suggestion )
Greetings,
http://subversion.tigris.org/issues/show_bug.cgi?id=3272
Patch suggestion is in attachment. It is allowing checkout of parent directory,
but I'm not sure that it will not break something else,
--
Regards, Denis.
Re: [PATCH] Issue 3272 ( suggestion )
Posted by Denis Pokataev <ca...@cpan.org>.
Pong :)
Yes, it doesn't cover issue 3272 fully, but it allows to checkout
directory without breaking sequence if versioned file is there.
I'm very sorry for breaking hacking rules. Will do my best next time
to follow it.
On Fri, Oct 31, 2008 at 12:26 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Ping.
>
> On a quick scan, you don't check the "assuming that the checkout is of the
> same URL that the existing wc represents" part described in the issue.
> (You want to check that the directory is version and from the same
> URL/repository/uuid as its parent.)
>
> Also, the code (1) uses tabs, and (2) is wrongly indented (even in the
> parts that use spaces). For (3), please don't use the *.c extension
> for patches --- *.diff, *.patch, and *.txt are preferred. (All of these
> are summarized at http://subversion.tigris.org/hacking.html, particularly
> in hacking.html#patches.)
>
> Thanks for the patch,
>
> Daniel
>
> Denis Pokataev wrote on Sun, 19 Oct 2008 at 17:36 +0400:
>> Greetings,
>>
>> http://subversion.tigris.org/issues/show_bug.cgi?id=3272
>>
>> Patch suggestion is in attachment. It is allowing checkout of parent directory,
>> but I'm not sure that it will not break something else,
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
--
Regards, Denis.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue 3272 ( suggestion )
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Ping.
On a quick scan, you don't check the "assuming that the checkout is of the
same URL that the existing wc represents" part described in the issue.
(You want to check that the directory is version and from the same
URL/repository/uuid as its parent.)
Also, the code (1) uses tabs, and (2) is wrongly indented (even in the
parts that use spaces). For (3), please don't use the *.c extension
for patches --- *.diff, *.patch, and *.txt are preferred. (All of these
are summarized at http://subversion.tigris.org/hacking.html, particularly
in hacking.html#patches.)
Thanks for the patch,
Daniel
Denis Pokataev wrote on Sun, 19 Oct 2008 at 17:36 +0400:
> Greetings,
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=3272
>
> Patch suggestion is in attachment. It is allowing checkout of parent directory,
> but I'm not sure that it will not break something else,
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org