You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Andrei Sekretenko (Jira)" <ji...@apache.org> on 2020/09/25 16:46:00 UTC
[jira] [Commented] (MESOS-10189) Pass offer constraints through the
V0 scheduler driver and its Java bindings.
[ https://issues.apache.org/jira/browse/MESOS-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202284#comment-17202284 ]
Andrei Sekretenko commented on MESOS-10189:
-------------------------------------------
{noformat}
commit 739a704a11f6cfc68ab6e035c7e945d8f5774303
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Tue Sep 22 14:55:13 2020 +0200
Added `OfferConstraints` validity criteria into protobuf comments.
Review: https://reviews.apache.org/r/72898
commit 242f49ee95e0bcac68d67e0d07f0ce5f3a133e87
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Tue Sep 22 14:55:43 2020 +0200
Added a test for creating a filter from default `OfferConstraints`.
Review: https://reviews.apache.org/r/72899
commit 28ff20d4990ec2097852a5cd16966628d89c31d3
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Thu Sep 24 16:12:46 2020 +0200
Made offer constraints filter and protobuf non-optional inside the code.
Given that Mesos now provides a guarantee that specifying no offer
constraint in UPDATE_FRAMEWORK/SUBSCRIBE call is equivalent to
specifying default-constructed `OfferConstraints`, and that we are
intending to make the V0 scheduler driver always require offer
constraints as an argument to the `updateFramework()`, it no longer
makes sense to keep `OfferConstraints`/`OfferConstraintsFilter`
optional inside the Mesos code base.
This patch replaces a non-set `Option<OfferConstraints>` with
default-constructed `OfferConstraints`, and a non-set
`Option<OfferConstraintsFilter>` with a default-constructed filter.
Review: https://reviews.apache.org/r/72897
commit fcfa3271c0c4fc2d8c6ae7cfd88cd82d26d2e1d1
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Wed Sep 16 12:25:19 2020 +0200
Added offer constraints to `MesosSchedulerDriver::updateFramework()`.
This patch adds an ability to set V0 framework's offer constraints
via the C++ V0 scheduler driver.
Review: https://reviews.apache.org/r/72874
commit 930c7e98d17e71192dae1d49b4b2217cc2dbd8b2 (HEAD -> master, origin/master, origin/HEAD)
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Wed Sep 16 12:28:24 2020 +0200
Added offer constraints to `updateFramework()` in the Java bindings.
Review: https://reviews.apache.org/r/72900
{noformat}
> Pass offer constraints through the V0 scheduler driver and its Java bindings.
> -----------------------------------------------------------------------------
>
> Key: MESOS-10189
> URL: https://issues.apache.org/jira/browse/MESOS-10189
> Project: Mesos
> Issue Type: Task
> Reporter: Andrei Sekretenko
> Assignee: Andrei Sekretenko
> Priority: Critical
>
> At the very least, in the updateFramework call.
> Passing through constructor is not that critical.
> Without this, the V0 frameworks (including Marathon, which is the primary candidate for adoption of offer constraints) will not be able to set the constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)