You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/23 13:53:00 UTC

[jira] [Commented] (ROCKETMQ-317) Make full use of Linux native libaio

    [ https://issues.apache.org/jira/browse/ROCKETMQ-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264356#comment-16264356 ] 

ASF GitHub Bot commented on ROCKETMQ-317:
-----------------------------------------

lizhanhui opened a new pull request #195: [ROCKETMQ-317] Take advantage of Linux native libaio
URL: https://github.com/apache/rocketmq/pull/195
 
 
   ## What is the purpose of the change
   
   This PR is to make use of the Linux native libaio interfaces in cases where mmap commit log files are no longer in main memory.  Two desired changes, in theory, will be brought about: 1) GC overhead is relieved as data is no longer passed through Java heap; 2) We can continue to use zero-copy.
   
   Discussions are welcome.
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make full use of Linux native libaio 
> -------------------------------------
>
>                 Key: ROCKETMQ-317
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-317
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Zhanhui Li
>            Assignee: vongosling
>
> libaio is a library, developed as part of the Linux kernel project. With libaio, writes are submitted to the operating system where they are processed asynchronously. When the writes have been processed, the operating system calls the code back.
> When messages being pulled were reclaimed out of main memory, making use of Linux native AIO system calls still allows zero-copy without blocking netty IO threads.
> https://activemq.apache.org/artemis/docs/latest/libaio.html
> https://www.ibm.com/developerworks/library/l-async/
> https://access.redhat.com/documentation/en-us/jboss_enterprise_application_platform/5/html/hornetq_user_guide/libaio
> https://stackoverflow.com/questions/8768083/difference-between-posix-aio-and-libaio-on-linux



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)