[GitHub] [incubator-pinot] snleee commented on a change in pull request #5576: Remove the code of printing the query plan

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #5576:
URL: https://github.com/apache/incubator-pinot/pull/5576#discussion_r441164899



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/ProjectionPlanNode.java
##########
@@ -21,27 +21,22 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Set;
-import javax.annotation.Nonnull;
 import org.apache.pinot.core.common.DataSource;
 import org.apache.pinot.core.indexsegment.IndexSegment;
 import org.apache.pinot.core.operator.ProjectionOperator;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 
 /**
  * The <code>ProjectionPlanNode</code> class provides the execution plan for fetching projection columns' data source
  * on a single segment.
  */
 public class ProjectionPlanNode implements PlanNode {
-  private static final Logger LOGGER = LoggerFactory.getLogger(ProjectionPlanNode.class);
-
   private final IndexSegment _indexSegment;
   private final Set<String> _projectionColumns;
   private final DocIdSetPlanNode _docIdSetPlanNode;
 
-  public ProjectionPlanNode(@Nonnull IndexSegment indexSegment, @Nonnull Set<String> projectionColumns,
-      @Nonnull DocIdSetPlanNode docIdSetPlanNode) {
+  public ProjectionPlanNode(IndexSegment indexSegment, Set<String> projectionColumns,

Review comment:
       Also, it would be great if we have some documented guidelines on `nullable & nonnull`

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/PlanNode.java
##########
@@ -18,25 +18,21 @@
  */
 package org.apache.pinot.core.plan;
 
+import org.apache.pinot.core.common.Block;
 import org.apache.pinot.core.common.Operator;
+import org.apache.pinot.spi.annotations.InterfaceAudience;
 
 
 /**
  * The <code>PlanNode</code> is a single execution plan node inside the {@link Plan} tree.
  */
+@InterfaceAudience.Private

Review comment:
       Do we have some documentation on the guideline for annotations? I think that at least all the committers should know where to put which annotations. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org