You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/03 20:24:14 UTC

[GitHub] [incubator-pekko] spangaer commented on a diff in pull request #8: Only allow Squash merges and update notification email addresses

spangaer commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko/pull/8#discussion_r1013364444


##########
.asf.yaml:
##########
@@ -21,3 +21,16 @@ github:
     issues: true
     # Enable projects for project management boards
     projects: false
+
+  enabled_merge_buttons:
+    squash:  true
+    merge:   false
+    rebase:  false

Review Comment:
   I can't help at wondering why generally rebase seems to be favorered over merge, given that it destroys commit signatures.
   
   If you want to respect commit signatures by default, merge should be allowed and rebase turned off in the UI.
   
   If needed rebasing can still be done locally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org