You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/03/23 04:57:31 UTC
[GitHub] chetanmeh commented on issue #3482: Controller protocol should be https in controller application.conf
chetanmeh commented on issue #3482: Controller protocol should be https in controller application.conf
URL: https://github.com/apache/incubator-openwhisk/issues/3482#issuecomment-375545270
With [this][1] change the [build passes][2]. It uses option 2 i.e. move config to reference.conf
```diff
diff --git a/core/controller/src/main/resources/application.conf b/core/controller/src/main/resources/application.conf
index bbc298b1e3..446d5fed34 100644
--- a/core/controller/src/main/resources/application.conf
+++ b/core/controller/src/main/resources/application.conf
@@ -2,16 +2,6 @@
include "logging"
include "akka-http-version"
-whisk {
- loadbalancer {
- invoker-busy-threshold: 4
- blackbox-fraction: 10%
- }
- controller {
- protocol: http
- }
-}
-
# http://doc.akka.io/docs/akka-http/current/scala/http/configuration.html
# descriptions inlined below for convenience
akka.http {
diff --git a/core/controller/src/main/resources/reference.conf b/core/controller/src/main/resources/reference.conf
new file mode 100644
index 0000000000..ce13c1e124
--- /dev/null
+++ b/core/controller/src/main/resources/reference.conf
@@ -0,0 +1,10 @@
+
+whisk {
+ loadbalancer {
+ invoker-busy-threshold: 4
+ blackbox-fraction: 10%
+ }
+ controller {
+ protocol: http
+ }
+}
```
@vvraskin Does this approach looks fine? I can then create a PR for the same
[1]: https://github.com/chetanmeh/incubator-openwhisk/compare/3243-coverage-1...chetanmeh:3243-coverage-1-3482
[2]: https://travis-ci.org/chetanmeh/incubator-openwhisk/builds/357224236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services