[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu removed a comment on pull request #2: SLING-10680 - Add support for versioning partials

[GitBox <gi...@apache.org>]

raducotescu removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889731364


   I was initially thinking that two partials should be equal irrespective of
   where they are coming from and hence wanted to force the various
   implementations to use the same hash algorithm.
   
   On Fri, 30 Jul 2021 at 10:21, Bertrand Delacretaz ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
   > <https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679743344>
   > :
   >
   > >
   >      /** Return a specific section of the partial, by name */
   >      @NotNull Optional<Section> getSection(SectionName name);
   >
   >      /** Names of the Partials on which this one depends */
   > -    @NotNull Set<String> getRequiredPartialNames();
   > +    @NotNull Set<PartialInfo> getRequiredPartialNames();
   > +
   > +    /**
   > +     * Returns the SHA256 hash of the source that was used to build this partial.
   > +     *
   > +     * @return the SHA256 hash of the source that was used to build this partial
   > +     */
   > +    @NotNull String getSHA256Hash();
   >
   > Shouldn't the name just be getDigest? The algorithm used is an
   > implementation detail IMHO
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#pullrequestreview-718839059>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AABJXH6Y7STAKTUST2ZY2SLT2JOJPANCNFSM5BGOWESQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org