You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Cheolsoo Park <pi...@gmail.com> on 2013/08/02 03:50:22 UTC

Review Request 13210: PIG-3374 CASE and IN fail when expression includes dereferencing operator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13210/
-----------------------------------------------------------

Review request for pig.


Bugs: PIG-3374
    https://issues.apache.org/jira/browse/PIG-3374


Repository: pig-git


Description
-------

CASE/IN fail when the lhs expression contains a dereference operator. Please see PIG-3374 for details:
https://issues.apache.org/jira/browse/PIG-3374


Diffs
-----

  src/org/apache/pig/parser/AliasMasker.g 98d94f7 
  src/org/apache/pig/parser/AstPrinter.g ccccd87 
  src/org/apache/pig/parser/AstValidator.g d0ed0e8 
  src/org/apache/pig/parser/LogicalPlanGenerator.g cc1f47e 
  src/org/apache/pig/parser/QueryParser.g d4d9700 
  test/org/apache/pig/test/TestCase.java 5d8f7f3 
  test/org/apache/pig/test/TestIn.java c3a55de 

Diff: https://reviews.apache.org/r/13210/diff/


Testing
-------

Added new test cases. All the unit tests pass.


Thanks,

Cheolsoo Park


Re: Review Request 13210: PIG-3374 CASE and IN fail when expression includes dereferencing operator

Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13210/#review25805
-----------------------------------------------------------

Ship it!


- Daniel Dai


On Aug. 2, 2013, 1:50 a.m., Cheolsoo Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13210/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 1:50 a.m.)
> 
> 
> Review request for pig.
> 
> 
> Bugs: PIG-3374
>     https://issues.apache.org/jira/browse/PIG-3374
> 
> 
> Repository: pig-git
> 
> 
> Description
> -------
> 
> CASE/IN fail when the lhs expression contains a dereference operator. Please see PIG-3374 for details:
> https://issues.apache.org/jira/browse/PIG-3374
> 
> 
> Diffs
> -----
> 
>   src/org/apache/pig/parser/AliasMasker.g 98d94f7 
>   src/org/apache/pig/parser/AstPrinter.g ccccd87 
>   src/org/apache/pig/parser/AstValidator.g d0ed0e8 
>   src/org/apache/pig/parser/LogicalPlanGenerator.g cc1f47e 
>   src/org/apache/pig/parser/QueryParser.g d4d9700 
>   test/org/apache/pig/test/TestCase.java 5d8f7f3 
>   test/org/apache/pig/test/TestIn.java c3a55de 
> 
> Diff: https://reviews.apache.org/r/13210/diff/
> 
> 
> Testing
> -------
> 
> Added new test cases. All the unit tests pass.
> 
> 
> Thanks,
> 
> Cheolsoo Park
> 
>