Re: [PR] feat: add rewrite manifests [iceberg-cpp]

["zhjwpku (via GitHub)" <gi...@apache.org>]

zhjwpku commented on PR #774:
URL: https://github.com/apache/iceberg-cpp/pull/774#issuecomment-5158936376

   > These comments are about the standalone update lifecycle:
   > 
   > * Registration must be mandatory so commit retries reapply the update.
   > * The temporary transaction must stay detached so its expired weak pointer does not break a later `Commit()`.
   > * No-op commits must still call `Finalize()` because cleanup is now delegated to `Transaction`.
   > 
   > Together, these keep one ownership, retry, and finalization path for standalone and explicit transactions.
   
   I think this standalone update lifecycle logic deserves a dedicated PR, so I do that in https://github.com/apache/iceberg-cpp/pull/868, please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org