introduce getword_conf_s?

[André Malo <nd...@perlig.de>]

We have a PR (16631) that mentions that at least one error log entry is not 
assigned to the appropriate error log (in 1.3). The warning is written by 
ap_getword_conf, which doesn't know anything about server_rec structures.

I've discovered this by trying to forward port this feature. However, I'd 
really like to see this warning to go into 2.1 and here written to the 
right log. What do you think about introducing a wrapper around 
ap_getword_conf, called ap_getword_conf_s (or similar, suggestions welcome 
;-)? It would take server_rec *s as a third argument and could write the 
warning into the right place.

nd
-- 
print "Just Another Perl Hacker";

# André Malo, <http://pub.perlig.de/> #

Re: introduce getword_conf_s?

[André Malo <nd...@perlig.de>]

* Justin Erenkrantz wrote:

> Eek.  Is it really worth emitting a warning on #'s not occurring at position 0
> in the line?

I agree with Joshua (see 
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17639>); yes it would be 
useful, but it's not so helpful if only written into the main error log.

> Seems like I'd prefer that this warning should be done at a
> higher level than ap_getword_conf (at a level which has access to server_rec).
> I'd prefer not to clutter up the interface just for *that*.  -- justin

yes, that was what ap_getword_conf_s (or somewhat) was meant for ;-). Just 
for centralizing the stuff, that's used in:

$ grep -r -l ap_getword_conf *
include/httpd.h
modules/aaa/mod_authz_groupfile.c
modules/aaa/mod_authz_user.c
modules/experimental/mod_auth_ldap.c
modules/generators/mod_autoindex.c
modules/http/mod_mime.c
modules/mappers/mod_rewrite.c
modules/mappers/mod_userdir.c
modules/metadata/mod_expires.c
modules/metadata/mod_headers.c
modules/metadata/mod_setenvif.c
modules/metadata/mod_usertrack.c
modules/proxy/mod_proxy.c
modules/proxy/proxy_ftp.c
modules/ssl/ssl_engine_config.c
os/unix/unixd.c
server/config.c
server/core.c
server/util.c
server/vhost.c

The ap_getword_conf interface itself should not be touched, right.

nd
-- 
die (eval q-qq[Just Another Perl Hacker
]
;-)
# André Malo, <http://www.perlig.de/> #

Re: introduce getword_conf_s?

[Justin Erenkrantz <ju...@erenkrantz.com>]

--On Thursday, March 6, 2003 11:41 PM +0100 André Malo <nd...@perlig.de> wrote:

> We have a PR (16631) that mentions that at least one error log entry is not
> assigned to the appropriate error log (in 1.3). The warning is written by
> ap_getword_conf, which doesn't know anything about server_rec structures.
>
> I've discovered this by trying to forward port this feature. However, I'd
> really like to see this warning to go into 2.1 and here written to the
> right log. What do you think about introducing a wrapper around
> ap_getword_conf, called ap_getword_conf_s (or similar, suggestions welcome
> ;-)? It would take server_rec *s as a third argument and could write the
> warning into the right place.

Eek.  Is it really worth emitting a warning on #'s not occurring at position 0 
in the line?  Seems like I'd prefer that this warning should be done at a 
higher level than ap_getword_conf (at a level which has access to server_rec). 
I'd prefer not to clutter up the interface just for *that*.  -- justin