[jira] [Commented] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

["Manfred Baedke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743553#comment-14743553 ] 

Manfred Baedke commented on OAK-3396:
-------------------------------------

Hi [~egli],

The patch looks sensible, but note that LdapIdentityProvider has method pairs createUser()/createGroup() and listUsers()/listGroups() that have almost identical code. Since it's at least the second time I see only one of the methods patched, I think this should be refactored.

> NPE during syncAllExternalUsers in LdapIdentityProvider.createUser
> ------------------------------------------------------------------
>
>                 Key: OAK-3396
>                 URL: https://issues.apache.org/jira/browse/OAK-3396
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-ldap
>    Affects Versions: 1.0.18
>            Reporter: Stefan Egli
>            Priority: Minor
>             Fix For: 1.0.20
>
>         Attachments: OAK-3396.patch
>
>
> When executing the JMX method syncAllExternalUsers the following NPE has been encountered. This likely indicates that - for a particular user - there is no attribute '{{uid}}':
> {code}
> java.lang.NullPointerException
> at org.apache.jackrabbit.oak.security.authentication.ldap.impl.LdapIdentityProvider.createUser(LdapIdentityProvider.java:667)
> at org.apache.jackrabbit.oak.security.authentication.ldap.impl.LdapIdentityProvider.access$000(LdapIdentityProvider.java:88)
> at org.apache.jackrabbit.oak.security.authentication.ldap.impl.LdapIdentityProvider$1.getNext(LdapIdentityProvider.java:281)
> at org.apache.jackrabbit.oak.security.authentication.ldap.impl.LdapIdentityProvider$1.getNext(LdapIdentityProvider.java:273)
> at org.apache.jackrabbit.commons.iterator.AbstractLazyIterator.hasNext(AbstractLazyIterator.java:39)
> at org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SyncMBeanImpl$Delegatee.syncAllExternalUsers(SyncMBeanImpl.java:245)
> at org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SyncMBeanImpl.syncAllExternalUsers(SyncMBeanImpl.java:426)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)