You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pradeep Soundararajan <pr...@citrix.com> on 2012/07/27 19:53:57 UTC

Re: Review Request: [Enhancement] CS-15694: Remove MYSQL connector

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6180/
-----------------------------------------------------------

(Updated July 27, 2012, 5:53 p.m.)


Review request for cloudstack and Rajesh Battala.


Description
-------

[Enhancement] CS-15694: Remove MYSQL connector

[Problem]
CloudStack uses a significant amount of third party software. As part of the move to ASF there is a certain set of licenses that are compatible with ASF policy.
We need to make sure that every dependency we have is in that set. If it's not we have to remove it.

[Solution]
Removed MYSQL connector

[Reviewers]
Rajesh, Kelven, Alex

[Testing]
    [Test Cases]
      Removed MYSQL connector jars and its dependencies. Able to execute ant build-all

    [Platform]
	Ubuntu


Diffs
-----

  deps/awsapi-lib/mysql-connector-java-5.1.7-bin.jar ebfe06861ac3d32cc8a5735b409a9118e7f08fe6 
  deps/cloud-mysql-connector-java-5.1.7-bin.jar ebfe06861ac3d32cc8a5735b409a9118e7f08fe6 
  server/src/com/cloud/cluster/ClusterManagerImpl.java 4f7cf6f5e0bef305ca1fde3ab1f8667b7807dd8f 

Diff: https://reviews.apache.org/r/6180/diff/


Testing
-------


Thanks,

Pradeep Soundararajan


Re: Review Request: [Enhancement] CS-15694: Remove MYSQL connector

Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6180/#review10175
-----------------------------------------------------------

Ship it!


- Rajesh Battala


On July 27, 2012, 5:53 p.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6180/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 5:53 p.m.)
> 
> 
> Review request for cloudstack and Rajesh Battala.
> 
> 
> Description
> -------
> 
> [Enhancement] CS-15694: Remove MYSQL connector
> 
> [Problem]
> CloudStack uses a significant amount of third party software. As part of the move to ASF there is a certain set of licenses that are compatible with ASF policy.
> We need to make sure that every dependency we have is in that set. If it's not we have to remove it.
> 
> [Solution]
> Removed MYSQL connector
> 
> [Reviewers]
> Rajesh, Kelven, Alex
> 
> [Testing]
>     [Test Cases]
>       Removed MYSQL connector jars and its dependencies. Able to execute ant build-all
> 
>     [Platform]
> 	Ubuntu
> 
> 
> Diffs
> -----
> 
>   deps/awsapi-lib/mysql-connector-java-5.1.7-bin.jar ebfe06861ac3d32cc8a5735b409a9118e7f08fe6 
>   deps/cloud-mysql-connector-java-5.1.7-bin.jar ebfe06861ac3d32cc8a5735b409a9118e7f08fe6 
>   server/src/com/cloud/cluster/ClusterManagerImpl.java 4f7cf6f5e0bef305ca1fde3ab1f8667b7807dd8f 
> 
> Diff: https://reviews.apache.org/r/6180/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Re: Review Request: [Enhancement] CS-15694: Remove MYSQL connector

Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6180/#review9546
-----------------------------------------------------------

Ship it!


Ship It!

- Kelven Yang


On July 27, 2012, 5:53 p.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6180/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 5:53 p.m.)
> 
> 
> Review request for cloudstack and Rajesh Battala.
> 
> 
> Description
> -------
> 
> [Enhancement] CS-15694: Remove MYSQL connector
> 
> [Problem]
> CloudStack uses a significant amount of third party software. As part of the move to ASF there is a certain set of licenses that are compatible with ASF policy.
> We need to make sure that every dependency we have is in that set. If it's not we have to remove it.
> 
> [Solution]
> Removed MYSQL connector
> 
> [Reviewers]
> Rajesh, Kelven, Alex
> 
> [Testing]
>     [Test Cases]
>       Removed MYSQL connector jars and its dependencies. Able to execute ant build-all
> 
>     [Platform]
> 	Ubuntu
> 
> 
> Diffs
> -----
> 
>   deps/awsapi-lib/mysql-connector-java-5.1.7-bin.jar ebfe06861ac3d32cc8a5735b409a9118e7f08fe6 
>   deps/cloud-mysql-connector-java-5.1.7-bin.jar ebfe06861ac3d32cc8a5735b409a9118e7f08fe6 
>   server/src/com/cloud/cluster/ClusterManagerImpl.java 4f7cf6f5e0bef305ca1fde3ab1f8667b7807dd8f 
> 
> Diff: https://reviews.apache.org/r/6180/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>