You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 17:33:45 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #11240:
[FLINK-16190][e2e] Migrate tests to FlinkResource
azagrebin commented on a change in pull request #11240: [FLINK-16190][e2e] Migrate tests to FlinkResource
URL: https://github.com/apache/flink/pull/11240#discussion_r385795737
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/StreamingKafkaITCase.java
##########
@@ -68,20 +69,22 @@
public final KafkaResource kafka;
@Rule
- public final FlinkResource flink = FlinkResource.get();
+ public final FlinkResource flink = FlinkResource.get(FlinkResourceSetup.builder().addConfiguration(getConfiguration()).build());
public StreamingKafkaITCase(final String kafkaExampleJarPattern, final String kafkaVersion) {
this.kafkaExampleJar = TestUtils.getResourceJar(kafkaExampleJarPattern);
this.kafka = KafkaResource.get(kafkaVersion);
}
- @Test
- public void testKafka() throws Exception {
+ private static Configuration getConfiguration() {
Review comment:
I would put it before the constructor for code style
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services