You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by arusinha <gi...@git.apache.org> on 2017/10/09 17:46:09 UTC

[GitHub] incubator-netbeans pull request #111: Removed failing tests dependent on del...

GitHub user arusinha opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/111

    Removed failing tests dependent on deleted resource foo.jks

    Removing TestFile  org.netbeans.modules.autoupdate.services.VerifyFileTest as it requires resource foo.jks which was deleted during Apache Code Donation

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arusinha/incubator-netbeans remove-failing-test-verifyfiletest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit 1d1426eff0f604741e75edb175d7748c83f34330
Author: Arunava Sinha <ar...@oradev.oraclecorp.com>
Date:   2017-10-09T17:23:57Z

    Removed failing tests dependent on deleted resource foo.jks

----


---

[GitHub] incubator-netbeans issue #111: Removed failing tests dependent on deleted re...

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/111
  
    A different approach to deleting the test would be to fix it. The keystore and the jars could be created at test time and then used.
    
    In anycase I would not delete it - in the worst case comment it out, but don't remove it.


---