[GitHub] [mynewt-core] ccollins476ad commented on a change in pull request #1933: Logging Header Image Hash

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #1933: Logging Header Image Hash
URL: https://github.com/apache/mynewt-core/pull/1933#discussion_r309801545
 
 

 ##########
 File path: sys/log/full/src/log_nmgr.c
 ##########
 @@ -148,6 +150,9 @@ log_nmgr_encode_entry(struct log *log, struct log_offset *log_offset,
         return MGMT_ERR_ECORRUPT;
     }
 
+    g_err |= cbor_encode_text_stringz(&rsp, "flag");
+    g_err |= cbor_encode_uint(&rsp, ueh->ue_flag);
 
 Review comment:
   Sorry for the late comment.  In my opinion, we should not include flags in the newtmgr response.  This just makes the response bigger without providing additional information.  The presence / absence of the image hash is what the client cares about, and it can determine that without seeing the flags.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services