You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/02/14 19:54:39 UTC

[GitHub] tinkerpop issue #557: TINKERPOP-1633 use official jbcrypt 0.4 in maven centr...

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/557
  
    I've had some time to review this. I have a few additional tweaks if you don't mind. In the pom.xml you edited you can removed this `<repository>`:
    
    ```xml
    <repository>
      <id>jitpack.io</id>
      <url>https://jitpack.io</url>
    </repository>
    ```
    
    You can also remove this entry in the docs:
    
    https://github.com/apache/tinkerpop/blame/2decc8132ff8726e35e722b8b35475dfa4b2b47c/docs/src/reference/gremlin-applications.asciidoc#L53
    
    There is an entry in `grapeConfig.xml` in the docker directories and a second entry on the gremlin-applications.asciidoc, but both look like those changes were added on the tp32 branch and not here on tp31 - I will take care of that stuff after merging your PR.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---