You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2017/12/20 05:33:54 UTC

[GitHub] carbondata pull request #1688: [CARBONDATA-1916]Correct the database locatio...

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1688

    [CARBONDATA-1916]Correct the database location path during carbon drop database

    Correct the database location path during carbon drop database
    
    when drop database is called, to delete the databsae directory, the path formed is wrong, so when drop datasbe is executed, operation is successful , but the database directory is still present in hdfs
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
     - [X] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
         YES, DONE IN ANT CLUSTER 
      
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata dropdb

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1688
    
----
commit 9d4278fad8a030096c99dcf547533d6bb78d250a
Author: akashrn5 <ak...@...>
Date:   2017-12-20T05:28:23Z

    Correct the database location path during carbon drop database

----


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1011/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1210/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2608/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    retest this please


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2662/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2493/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2448/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2490/



---

[GitHub] carbondata pull request #1688: [CARBONDATA-1916]Correct the database locatio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1688


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    retest this please


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1265/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1268/



---

[GitHub] carbondata pull request #1688: [CARBONDATA-1916]Correct the database locatio...

Posted by akashrn5 <gi...@git.apache.org>.
GitHub user akashrn5 reopened a pull request:

    https://github.com/apache/carbondata/pull/1688

    [CARBONDATA-1916]Correct the database location path during carbon drop database

    Correct the database location path during carbon drop database
    
    when drop database is called, to delete the databsae directory, the path formed is wrong, so when drop datasbe is executed, operation is successful , but the database directory is still present in hdfs
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
     - [X] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
         YES, DONE IN ANT CLUSTER 
      
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata dropdb

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1688
    
----
commit 8b813816b23a911c4ea4b42c2b55b98ee61c3bbe
Author: akashrn5 <ak...@...>
Date:   2017-12-20T05:28:23Z

    Correct the database location path during carbon drop database

----


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1262/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    retest this please


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    LGTM


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2302/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2510/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    retest this please


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    retest this please


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1277/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2505/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1287/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2486/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1086/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2412/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2459/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2502/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    retest this please


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2669/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2446/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    LGTM


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2235/



---

[GitHub] carbondata pull request #1688: [CARBONDATA-1916]Correct the database locatio...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 closed the pull request at:

    https://github.com/apache/carbondata/pull/1688


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1281/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2667/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    retest sdv please


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1264/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    LGTM


---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2489/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1226/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1189/



---

[GitHub] carbondata issue #1688: [CARBONDATA-1916]Correct the database location path ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1688
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2434/



---