[GitHub] fhueske opened a new pull request #6423: [FLINK-9935] [table] Fix incorrect group field access in batch window combiner.

[GitBox <gi...@apache.org>]

fhueske opened a new pull request #6423: [FLINK-9935] [table] Fix incorrect group field access in batch window combiner.
URL: https://github.com/apache/flink/pull/6423
 
 
   ## What is the purpose of the change
   
   Fixes an incorrect field access (on a grouping field) in the combiner for a TUMBLE or HOP group window in a batch query. The incorrect field access would typically result in a ClassCastException or lead to incorrect results.
   
   ## Brief change log
   
   * fix the field access in the generated aggregation code.
   * modify tests to fail if the field access is invalid
   
   ## Verifying this change
   
   * the modified tests validate the correct access.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **n/a**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services