[jira] [Comment Edited] (YARN-9998) Code cleanup in LeveldbConfigurationStore

["Szilard Nemeth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067598#comment-17067598 ] 

Szilard Nemeth edited comment on YARN-9998 at 3/26/20, 12:26 PM:
-----------------------------------------------------------------

Thanks [~bteke] for this patch, looks good to me, committed to trunk.
Thanks [~adam.antal] for the review.

Can you please backport this patch to branch-3.2 if it makes sense?
Thanks.


was (Author: snemeth):
Thanks [~bteke] for this patch, looks good to me, committed to trunk.

Can you please backport this patch to branch-3.2 if it makes sense?
Thanks.

> Code cleanup in LeveldbConfigurationStore
> -----------------------------------------
>
>                 Key: YARN-9998
>                 URL: https://issues.apache.org/jira/browse/YARN-9998
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Benjamin Teke
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: YARN-9998.001.patch, YARN-9998.002.patch
>
>
> Many things can be improved:
> * Field compactionTimer could be a local variable
> * Field versiondb should be camelcase
> * initDatabase is a very long method: Initialize db / versionDb should be in separate methods, split this method into smaller chunks
> * Remove TODOs
> * Remove duplicated code block in LeveldbConfigurationStore.CompactionTimerTask
> * Any other cleanup



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org