[GitHub] [hbase] Apache9 commented on a change in pull request #3244: HBASE-25869 WAL value compression

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629777261



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##########
@@ -34,21 +36,49 @@
 @InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC, HBaseInterfaceAudience.PHOENIX})
 public class CompressionContext {
 
-  static final String ENABLE_WAL_TAGS_COMPRESSION =
+  public static final String ENABLE_WAL_TAGS_COMPRESSION =
       "hbase.regionserver.wal.tags.enablecompression";
 
+  public static final String ENABLE_WAL_VALUE_COMPRESSION =
+      "hbase.regionserver.wal.value.enablecompression";
+
   public enum DictionaryIndex {
     REGION, TABLE, FAMILY, QUALIFIER, ROW
   }
 
+  static class ValueCompressor {
+    final Deflater deflater;
+    final Inflater inflater;
+
+    public ValueCompressor() {
+      deflater = new Deflater();
+      inflater = new Inflater();

Review comment:
       The append is single threaded, so I do not think the synchronized itself would cause much overhead.
   
   But for performance, on modern hardwares, with powerful NIC and SSD, now the bottleneck may become CPU so enable compression itself may impact performance.
   
   But anyway, you could choose not enable it if the bottleneck on your cluster is CPU so it is not a blocker for adding compression support.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org