You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/02/22 07:40:00 UTC

[jira] [Commented] (IMPALA-11869) Use to_string() in PrintValue for printing Thrift types

    [ https://issues.apache.org/jira/browse/IMPALA-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691987#comment-17691987 ] 

ASF subversion and git services commented on IMPALA-11869:
----------------------------------------------------------

Commit 88a7538af79afc19233cdfe3220e3c25e7edd16d in impala's branch refs/heads/master from Daniel Becker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=88a7538af ]

IMPALA-11869: Use to_string() in PrintValue for printing Thrift types

IMPALA-11645 introduced the function PrintValue() which we use to
convert Thrift types to strings. This function used operator<<,
which is provided for the generated Thrift types. However, Thrift also
generates a to_string() function that is overloaded for Thrift types. It
would be more efficient to use this instead of involving streams with
operator<<.

This change reimplements PrintValue() using to_string() instead of
operator<<.

Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Reviewed-on: http://gerrit.cloudera.org:8080/19487
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Use to_string() in PrintValue for printing Thrift types
> -------------------------------------------------------
>
>                 Key: IMPALA-11869
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11869
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Daniel Becker
>            Assignee: Daniel Becker
>            Priority: Minor
>
> The change _IMPALA-11645: Remove PrintThriftEnum functions in debug-util.cc_ introduced the function {{PrintValue()}} which we use to convert Thrift types to strings. This function now uses {{{}operator<<{}}}, which is provided for the generated thrift types. However, Thrift also generates a {{to_string()}} function that is overloaded for Thrift types. It would be more efficient to use this instead of involving streams with {{{}operator<<{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org