You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Olivier Ribardière (JIRA)" <ji...@apache.org> on 2009/07/23 14:53:14 UTC
[jira] Created: (WICKET-2393) Passwords should not be trimed
Passwords should not be trimed
------------------------------
Key: WICKET-2393
URL: https://issues.apache.org/jira/browse/WICKET-2393
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC5
Reporter: Olivier Ribardière
Priority: Minor
When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimed by the PasswordTextField class.
Passwords should not be trimed.
Resolution is probably to override the convertValue method in the PasswordTextField class but I am not confident in doing that myself....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2393) Passwords should not be trimmed
Posted by "Olivier Ribardière (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Ribardière updated WICKET-2393:
---------------------------------------
Affects Version/s: 1.4.0
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Priority: Minor
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2393) Passwords should not be trimmed
Posted by "Olivier Ribardière (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Ribardière updated WICKET-2393:
---------------------------------------
Fix Version/s: (was: 1.4.1)
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Priority: Minor
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2393) Passwords should not be trimed
Posted by "Olivier Ribardière (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Ribardière updated WICKET-2393:
---------------------------------------
Attachment: WICKET-2393-fix.patch
A patch has been attached to this bug, please indicate if any problem with it.
> Passwords should not be trimed
> ------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC5
> Reporter: Olivier Ribardière
> Priority: Minor
> Attachments: WICKET-2393-fix.patch
>
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class but I am not confident in doing that myself....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2393) Passwords should not be trimmed
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2393:
----------------------------------
Fix Version/s: 1.5-M1
we cannot tweak this for 1.4 because it would change existing behavior and would require code modifications from the users. you will have to fix it yourself for now in your own code.
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Priority: Minor
> Fix For: 1.5-M1
>
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2393) Passwords should not be trimmed
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2393.
----------------------------------------
Resolution: Won't Fix
Fix Version/s: (was: 1.5-M1)
1.4.2
Assignee: Juergen Donnerstag
you may subclass shouldTrimInput() and return false.
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2393) Passwords should not be trimmed
Posted by "Philippe Laflamme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785958#action_12785958 ]
Philippe Laflamme commented on WICKET-2393:
-------------------------------------------
Why not base the decision on other password entry systems?
Here's the behaviour of some sites/systems:
* JIRA: does not trim
* Google: trims
* Drupal: trims
* sshd: does not trim
* GDM: does not trim
* Hotmail: does not trim
* Windows: does not trim
If the password was created using the same behaviour, all this discussion is moot, because no one will ever notice whether their password is being trimmed or not...
My suggestion: offer a method for setting the desired behaviour and keep the current trimming behaviour as default.
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2393) Passwords should not be trimmed
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770124#action_12770124 ]
James Carman commented on WICKET-2393:
--------------------------------------
Is the consensus that the password field should never trim? I don't know about that. What if you copy/paste a password from your email and you accidentally include a space at the end or something? I have never used a leading/trailing space on my passwords (or a space in the middle for that matter). Is this a common practice? I like Juergen's suggestion of having the user override shouldTripInput() if they want a non-trimming password field.
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2393) Passwords should not be trimmed
Posted by "Olivier Ribardière (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Ribardière updated WICKET-2393:
---------------------------------------
Fix Version/s: 1.4.1
Description:
When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
Passwords should not be trimed.
Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
was:
When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimed by the PasswordTextField class.
Passwords should not be trimed.
Resolution is probably to override the convertValue method in the PasswordTextField class but I am not confident in doing that myself....
Affects Version/s: (was: 1.4-RC5)
1.4.0
Remaining Estimate: 1h
Original Estimate: 1h
Summary: Passwords should not be trimmed (was: Passwords should not be trimed)
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2393) Passwords should not be trimmed
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786102#action_12786102 ]
Juergen Donnerstag commented on WICKET-2393:
--------------------------------------------
as I said: you may subclass shouldTrimInput() and return false.
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4.2
>
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2393) Passwords should not be trimmed
Posted by "Olivier Ribardière (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Ribardière updated WICKET-2393:
---------------------------------------
Affects Version/s: (was: 1.4.0)
> Passwords should not be trimmed
> -------------------------------
>
> Key: WICKET-2393
> URL: https://issues.apache.org/jira/browse/WICKET-2393
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Olivier Ribardière
> Priority: Minor
> Attachments: WICKET-2393-fix.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the SignInPanel, if password input field contains spaces at the begining or at the end, they are trimmed by the PasswordTextField class.
> Passwords should not be trimed.
> Resolution is probably to override the convertValue method in the PasswordTextField class. I provided a patch (attached to this issue), please indicate if any problem with it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.