You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/06/28 21:45:20 UTC

Review Request 67775: ATLAS-2769: Atlas start just after the upgrade fails with "TableNotFoundException: atlas_janus" exception

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67775/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2769
    https://issues.apache.org/jira/browse/ATLAS-2769


Repository: atlas


Description
-------

Retrying AtlasGraphProvider.getInstance() 3 times for 30 secs


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 55934c38f 


Diff: https://reviews.apache.org/r/67775/diff/1/


Testing
-------

In progress


Thanks,

Sarath Subramanian


Re: Review Request 67775: ATLAS-2769: Atlas start just after the upgrade fails with "TableNotFoundException: atlas_janus" exception

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67775/#review205564
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 28, 2018, 10:04 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67775/
> -----------------------------------------------------------
> 
> (Updated June 28, 2018, 10:04 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2769
>     https://issues.apache.org/jira/browse/ATLAS-2769
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Retrying AtlasGraphProvider.getInstance() 3 times for 30 secs
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 55934c38f 
> 
> 
> Diff: https://reviews.apache.org/r/67775/diff/2/
> 
> 
> Testing
> -------
> 
> In progress
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Re: Review Request 67775: ATLAS-2769: Atlas start just after the upgrade fails with "TableNotFoundException: atlas_janus" exception

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67775/
-----------------------------------------------------------

(Updated June 28, 2018, 3:04 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.


Changes
-------

addressed review comments.


Bugs: ATLAS-2769
    https://issues.apache.org/jira/browse/ATLAS-2769


Repository: atlas


Description
-------

Retrying AtlasGraphProvider.getInstance() 3 times for 30 secs


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 55934c38f 


Diff: https://reviews.apache.org/r/67775/diff/2/

Changes: https://reviews.apache.org/r/67775/diff/1-2/


Testing
-------

In progress


Thanks,

Sarath Subramanian


Re: Review Request 67775: ATLAS-2769: Atlas start just after the upgrade fails with "TableNotFoundException: atlas_janus" exception

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67775/#review205535
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java
Lines 119 (patched)
<https://reviews.apache.org/r/67775/#comment288434>

    return APPLICATION_PROPERTIES == null ? 3 : APPLICATION_PROPERTIES.getInt(GRAPH_REPOSITORY_MAX_RETRIES, 3);



repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java
Lines 125 (patched)
<https://reviews.apache.org/r/67775/#comment288435>

    return APPLICATION_PROPERTIES == null ? 30000 : APPLICATION_PROPERTIES.getLong(GRAPH_REPOSITORY_RETRY_SLEEPTIME, 30000);


- Madhan Neethiraj


On June 28, 2018, 9:45 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67775/
> -----------------------------------------------------------
> 
> (Updated June 28, 2018, 9:45 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2769
>     https://issues.apache.org/jira/browse/ATLAS-2769
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Retrying AtlasGraphProvider.getInstance() 3 times for 30 secs
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 55934c38f 
> 
> 
> Diff: https://reviews.apache.org/r/67775/diff/1/
> 
> 
> Testing
> -------
> 
> In progress
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>