[GitHub] [dolphinscheduler] SbloodyS commented on a change in pull request #8407: [Fix-8367][Master] execute COMPLEMENT_DATA command always missing some ack event

[GitBox <gi...@apache.org>]

SbloodyS commented on a change in pull request #8407:
URL: https://github.com/apache/dolphinscheduler/pull/8407#discussion_r808640404



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -480,28 +481,45 @@ private boolean processComplementData() throws Exception {
                     processInstance.getScheduleTime(),
                     complementListDate.toString());
             scheduleDate = complementListDate.get(index + 1);
-            //the next process complement
-            processInstance.setId(0);
+
+        }
+
+        this.taskInstanceHashMap.clear();

Review comment:
       I'll remove it.

##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -480,28 +481,45 @@ private boolean processComplementData() throws Exception {
                     processInstance.getScheduleTime(),
                     complementListDate.toString());
             scheduleDate = complementListDate.get(index + 1);
-            //the next process complement
-            processInstance.setId(0);
+
+        }
+
+        this.taskInstanceHashMap.clear();
+
+        //the next process complement
+        int create = this.createComplementDataCommand(scheduleDate);
+        if (create > 0) {
+            logger.info("create complement data command successfully.");

Review comment:
       I'll add it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org