[GitHub] aharui commented on issue #317: Service classes emulated

[GitBox <gi...@apache.org>]

aharui commented on issue #317: Service classes emulated
URL: https://github.com/apache/royale-asjs/pull/317#issuecomment-430389486
 
 
   It looks pretty good, but there are some places where a method has both a COMPILE::SWF version and a COMPILE::JS version and there aren't any obvious differences between them.  It would be better to have one multi-platform version without COMPILE::SWF/COMPILE::JS and put COMPILE::SWF and COMPILE::JS blocks in the method body for any differences.
   
   In some cases, the fact that there are different imports for JS vs SWF is good enough.  The same method body will use the JS import when compiled for JS and the SWF import when compiled for SWF.
   
   Also, I don't see any need to try to retain any of the RESULT_FORMAT_XML code for the SWF version.  We should just leave it out until someone really needs it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services