You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/26 08:21:16 UTC

[GitHub] [spark] MaxGekk opened a new pull request, #37997: [SPARK-40560][SQL] Rename `message` to `messageFormat` in the `STANDARD` format of errors

MaxGekk opened a new pull request, #37997:
URL: https://github.com/apache/spark/pull/37997

   ### What changes were proposed in this pull request?
   In the `STANDARD` format of error messages, rename the `message` field to `messageFormat`.
   
   ### Why are the changes needed?
   Because the field contains a format (or template) of an error message, actually.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes.
   
   ### How was this patch tested?
   By running the affected test suites:
   ```
   $ build/sbt "core/testOnly *SparkThrowableSuite"
   $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly org.apache.spark.sql.hive.thriftserver.CliSuite"
   $ build/sbt -Phive -Phive-thriftserver "test:testOnly *ThriftServerWithSparkContextInBinarySuite"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #37997: [SPARK-40560][SQL] Rename `message` to `messageFormat` in the `STANDARD` format of errors

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37997:
URL: https://github.com/apache/spark/pull/37997#issuecomment-1257670954

   also cc @srielau @anchovYu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk closed pull request #37997: [SPARK-40560][SQL] Rename `message` to `messageTemplate` in the `STANDARD` format of errors

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37997: [SPARK-40560][SQL] Rename `message` to `messageTemplate` in the `STANDARD` format of errors
URL: https://github.com/apache/spark/pull/37997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #37997: [SPARK-40560][SQL] Rename `message` to `messageTemplate` in the `STANDARD` format of errors

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37997:
URL: https://github.com/apache/spark/pull/37997#issuecomment-1257891327

   Merging to master. Thank you, @cloud-fan for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org