You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by tterstep <gi...@git.apache.org> on 2017/08/02 23:49:32 UTC
[GitHub] storm pull request #2258: addition of isDebugEnabled() check to improve the ...
GitHub user tterstep opened a pull request:
https://github.com/apache/storm/pull/2258
addition of isDebugEnabled() check to improve the performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tterstep/storm DEBUG_ENABLED_CHECK
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2258.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2258
----
commit ca6c91001b74b0d0e5b9c4e20a4470cce502b031
Author: tigrant <ti...@socialcodeinc.com>
Date: 2017-08-02T23:48:14Z
addition of isDebugEnabled() check to improve the performance.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2258: addition of isDebugEnabled() check to improve the perform...
Posted by tterstep <gi...@git.apache.org>.
Github user tterstep commented on the issue:
https://github.com/apache/storm/pull/2258
@MichaelTimper
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2258: addition of isDebugEnabled() check to improve the ...
Posted by tterstep <gi...@git.apache.org>.
Github user tterstep closed the pull request at:
https://github.com/apache/storm/pull/2258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2258: addition of isDebugEnabled() check to improve the perform...
Posted by jnioche <gi...@git.apache.org>.
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/2258
-1
Why not simply use parameterized messages instead? See https://www.slf4j.org/faq.html#logging_performance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---